News for hackers. Stuff that matters.

A comment on Google takes the pain out of code reviews, with 97% dev satisfaction. Parent comment

Re:Google takes the pain out of code reviews, with 97% dev s... by thiht on Monday December 04, 2023 @02:10PM (#38521648)
> There won’t be any surprises in the review.

There can always be surprises. Sometimes when you see something implemented you can get a « click » as to why another solution would be better. It happens to me regularly both on the receiving and giving end of this and it’s rarely a big deal. Most of the time it happened to me, I could reuse the functional tests I had written and parts of the code anyway.

Reworking on something so that it’s better is never a waste of time, and it’s always better to do it before it reaches Prod.

[ Parent | on HN ]
Re:Google takes the pain out of code reviews, with 97% dev s... by withinboredom on Monday December 04, 2023 @02:20PM (#38521802)
Making a suggestion on how to do something better is quite a bit different than saying “this isn’t up to standard. Do not pass go. Do not collect $200”

We all see these suggestions. That’s ok, and wanted. But to say “ah, no I think it should be the other way.” [reject]

That’s what I was talking about here.

[ Parent | on HN ]