News for hackers. Stuff that matters.
Re:ZFS 2.2.1: Block Cloning disabled due to data corruption by ryao on Wednesday November 22, 2023 @11:12AM (#38381122)
A FreeBSD developer wrote this code.
Re:ZFS 2.2.1: Block Cloning disabled due to data corruption by gonzo on Wednesday November 22, 2023 @12:22PM (#38382063)
and then there were deep concerns about the stability of same, so vfs.zfs.bclone_enabled = 0 was left in-place

https://github.com/freebsd/freebsd-src/commit/068913e4ba3dd9...

Re:ZFS 2.2.1: Block Cloning disabled due to data corruption by keep_reading on Wednesday November 22, 2023 @12:19PM (#38382031)
So far nobody has proven that this bug exists on FreeBSD, though. :)
Re:ZFS 2.2.1: Block Cloning disabled due to data corruption by ryao on Wednesday November 22, 2023 @03:55PM (#38384968)
The bugs are in cross platform code beneath the VFS. They exist on FreeBSD too.
Re:ZFS 2.2.1: Block Cloning disabled due to data corruption by Always_Anon on Wednesday November 22, 2023 @12:37PM (#38382276)
Because FreeBSD is behind Linux in copying with reflinks. They couldn't even reproduce the issue if they wanted to.
Re:ZFS 2.2.1: Block Cloning disabled due to data corruption by ryao on Wednesday November 22, 2023 @06:33PM (#38386756)
This code was implemented for FreeBSD before it was implemented for Linux. I do not think it has made it to a FreeBSD release yet though.
Re:ZFS 2.2.1: Block Cloning disabled due to data corruption by mnd999 on Thursday November 23, 2023 @05:53AM (#38391479)
It’s in FreeBSD 14. But they disabled block cloning by default.
Re:ZFS 2.2.1: Block Cloning disabled due to data corruption by Always_Anon on Wednesday November 29, 2023 @02:31PM (#38464084)
No it wasn't: https://github.com/openzfs/zfs/issues/405

This hit Linux first, which is why Linux experienced the issue. FreeBSD does not currently have reflink cp.

Re:ZFS 2.2.1: Block Cloning disabled due to data corruption by jiripospisil on Thursday November 23, 2023 @10:42AM (#38393959)
Re:ZFS 2.2.1: Block Cloning disabled due to data corruption by keep_reading on Thursday November 23, 2023 @09:29PM (#38400116)
Looks like a deeper bug has been exposed due to the way bclone works? They're finding issues now on ZFS versions predating bclone

Edit: yep, it's an older bug. Set zfs_dmu_offset_next_sync=0 to save your data

https://github.com/openzfs/zfs/issues/15526#issuecomment-182...

Re:ZFS 2.2.1: Block Cloning disabled due to data corruption by jiripospisil on Friday November 24, 2023 @06:09AM (#38402739)
Not sure what's your point. The comment I linked to just confirmed that the bug (whichever it might be) has reproduced on FreeBSD.
Re:ZFS 2.2.1: Block Cloning disabled due to data corruption by keep_reading on Friday November 24, 2023 @11:22PM (#38411153)
Just following up for the readers of the thread
Re:ZFS 2.2.1: Block Cloning disabled due to data corruption by fortani on Friday November 24, 2023 @06:58PM (#38409736)
Nope, somebody managed to reproduce this issue even with zfs_dmu_offset_next_sync=0

https://github.com/openzfs/zfs/issues/15526#issuecomment-182...

Re:ZFS 2.2.1: Block Cloning disabled due to data corruption by keep_reading on Friday November 24, 2023 @11:20PM (#38411145)
Apply this patch, it appears to be the real fix.

https://github.com/openzfs/zfs/pull/15571/files?diff=split&w...