News for hackers. Stuff that matters.
Re:I got robbed of my first kernel contribution by arp242 on Wednesday September 27, 2023 @03:07PM (#37679661)
What usually happens is that someone sends a patch with a text description of the problem, but no test case. So what I do in those cases is just quickly look at the patch and create a test case first, on the current stable version, to reproduce the bug. This is both so that a test case exists, but also so that I have a deeper understanding of the problem.

When that is done, often the fix is simple, and the author's patch sometimes just ... isn't that great, often for entirely understandable reasons, so it's easier to just fix it myself "from scratch".

So whose patch is it then? In some cases the patch was useful and I'm "inspired" by it, in other cases I'm not. I tend to err on the side of caution, but I've definitely merged my share of patches where the Author field was, IMHO, kind of a lie.

As for code review: it's really time-consuming. And while a few "minor bug fixers" of today become "hard-core contributors" or tomorrow, realistically, most people show up to fix one bug and are never seen again. That's perfectly fine! But it does mean that "teaching" everyone who shows up quickly become an enormous time sink. There's a bit of a trade-off to be made here.

Re:I got robbed of my first kernel contribution by kazinator on Wednesday September 27, 2023 @09:54PM (#37684232)
"This change is closely based on a well-considered patch from A. U. Thor <[email protected]>, who also originated the bug report."

A. U. Thor can point to that 10 years later and say he or she fixed that; nobody cares if the maintainer changed a few things.