Re:I got robbed of my first kernel contribution
by JodieBenitez on Wednesday September 27, 2023 @10:41AM
(#37675338)
I don't think the number of lines is relevant. A patch is a patch and the author should be credited as such.
> Maybe it should work like that
Definitely
Re:I got robbed of my first kernel contribution
by ylyn on Wednesday September 27, 2023 @11:52AM
(#37676531)
> A patch is a patch and the author should be credited as such.
But the patch was not taken. The maintainer fixed it a different way. So credit is given for reporting the issue and suggesting a fix, and that is what is represented by the Reported-By. Is that so hard to understand?
Re:I got robbed of my first kernel contribution
by alexsmarsh on Wednesday September 27, 2023 @01:35PM
(#37678168)
its the suggesting a fix (ie doing the research) thats missed, anybody can point out a bug
This whole thing tastes to me like a pay-off for an unwanted gift, you don't go into this sort of an exchange on a security mailing list expecting kernel contributor credit for fixing a bug. That's just not how it works. Maybe it should work like that but it simply doesn't. OP had pre-set expectations and those were found to be in the wrong, nobody got 'robbed' and misrepresenting the exchange to one that makes the kernel maintainer seem like an asshole when that wasn't at all how it went down makes me feel even less good about the whole thing.
Reported-by ranges the gamut of 'I ran into this bug' to 'I found this issue and here is my patch, which I hope is useful to you'.
If you want to negotiate credit rules for 4 line patches up front you are of course welcome to do so but keep in mind that maintainers can and do accept patches, rewrite them and contribute them under their own name (and their responsibility), especially security patches.