News for hackers. Stuff that matters.
Re:Bun v1.0.0 by Touche on Friday September 08, 2023 @12:46PM (#37436040)
This problem is very old at this point. I'm doubtful that Bun has "solved it" any more than other tools. They've just selected a different set of trade-offs that will result in a different set of packages not working. Is there a reason to think they've cracked some code that other tools were unable to?
Re:Bun v1.0.0 by lhnz on Friday September 08, 2023 @12:55PM (#37436163)
Re:Bun v1.0.0 by eyelidlessness on Friday September 08, 2023 @12:50PM (#37436098)
The compiler is the bundler is the runtime. The reason it’s such a problem on Node is because the tools are separate and often conceptually at odds.
Re:Bun v1.0.0 by Touche on Friday September 08, 2023 @01:35PM (#37436722)
No, it's a problem because the formats are fundamentally incompatible and it's impossible to infer the author's intent. A package with no imports/exports or requires could be either ESM or CJS and no heuristic can solve for that reality.
Re:Bun v1.0.0 by AaronFriel on Friday September 08, 2023 @01:47PM (#37436904)
How common are packages with no imports, exports, requires, or "module.exports="?

I imagine that's quite rare, because such a package would only be imported or required for its side effects; and because that package cannot import or require any others, could you safely just assume that if it was `require()`ed use CJS, and if it was `import`ed, use ESM?

Re:Bun v1.0.0 by Touche on Friday September 08, 2023 @01:58PM (#37437062)
Rare things still happen a lot at the scale of npm. And due to transitive dependencies it winds up affecting a lot of actual users. And this is just one example of an incompatibility, there are many more. Bun didn't discover a silver bullet here that dozens of other tools in the past missed on.
Re:Bun v1.0.0 by AaronFriel on Friday September 08, 2023 @02:09PM (#37437202)
Do you have an empirical basis for that? I'm curious because on one hand, Bun is advertising they are solving a major challenge for library authors, really betting quite heavily on that being persuasive for adoption.

The risk for Bun's adoption is that they're wrong, of course.

The risk for Node's usage is that they're right, and library authors begin urging users to use Bun because it's 100x easier than making a useful library with Node. (This will happen very slowly, but things that happen very slowly can start happening all at once very quickly.)

Re:Bun v1.0.0 by fkyoureadthedoc on Friday September 08, 2023 @05:12PM (#37439495)
> And this is just one example of an incompatibility, there are many more

Such as? If you could provide 5-10 of your many examples and why you think that Bun's approach doesn't solve them it would be very helpful.

Re:Bun v1.0.0 by throw10920 on Friday September 08, 2023 @08:45PM (#37441083)
Yeah, I don't believe GP. Their assertions that Bun hasn't solved this (or that the heuristic used is inadequate) are basically based on speculation without any evidence.
Re:Bun v1.0.0 by 3np on Saturday September 09, 2023 @12:08AM (#37442205)
Jarred even came here and agree with them. It's nothing controversial. Just nuance. No need to flame. DYOR.
Re:Bun v1.0.0 by jwalton on Friday September 08, 2023 @06:47PM (#37440262)
Assuming it has no imports or requires, and no references to meta, it’s a bare JavaScript file, and whether you treat it as esm or cjs shouldn’t matter, no?
Re:Bun v1.0.0 by lhorie on Friday September 08, 2023 @10:04PM (#37441480)
JS has two top level grammars, one defaults to loose mode and the other defaults to strict mode, among other nuances.

Possibly the most devious nuance is whether the spec's appendix B applies, which affects whether html comment syntax is valid (yes, this is a thing). The html comment token can therefore be parsed either as a comment or as a series of operators depending on the grammar being used.

Effectively, this means it's possible to craft a program that does different things in CJS vs ESM mode.

Re:Bun v1.0.0 by Jarred on Friday September 08, 2023 @02:57PM (#37437848)
In Bun, you can use import and require in the same file. There's three steps for what makes this work:

1) We patched JavaScriptCore to load ES Modules synchronously when they don't use top-level await. The main tradeoff here is that requiring an ES Module which uses top-level await is unsupported (Bun throws an exception when you try to do this)

2) To support require() inside ES Modules, we add `import.meta.require` and have a transpiler integration to convert calls to module.require() or require() into import.meta.require(). This either loads the file as an ES Module or as a CommonJS module, depending on what the transpiler says it is

3) We rely on certain heuristics to decide whether a script is an ES Module or a CommonJS module. If they use certain sloppy mode or CommonJS-only features, it becomes CommonJS. If they use ESM features or it's somewhat ambiguous, it becomes an ES Module.

Re:Bun v1.0.0 by jwalton on Friday September 08, 2023 @06:45PM (#37440249)
I’ve often wondered why node doesn’t do 1 in this list. It would solve 95% of the problems, I’m sure.
Re:Bun v1.0.0 by jcheng on Friday September 08, 2023 @07:03PM (#37440373)
For 1), what about requiring an ES module that doesn’t itself use top-level await, but imports another ES module that uses top-level await?
Re:Bun v1.0.0 by Jarred on Friday September 08, 2023 @07:16PM (#37440475)
That throws since we cannot make it synchronous. It works by reading the internal state of the Promise and getting the value out of it if the Promise is fulfilled.
Re:Bun v1.0.0 by TimTheTinker on Friday September 08, 2023 @08:03PM (#37440835)
While I appreciate the convenience that will result from this excellent engineering, I'm concerned that this could result in a lot of mixed module files that now can only work with Bun.

Is there an option to require each file to only use CJS or ESM features, but not both? If not, may I suggest adding that option?

Re:Bun v1.0.0 by moritzwarhier on Friday September 08, 2023 @08:31PM (#37440998)
Seems like a case for ESLint and I agree with you.

Mixed require and import (the latter in both its static and dynamic variants) is already possible with Webpack and Vite.

I hate it and would complain about any code introducing this in any kind of review.

It's great for integration, full stop.

This is an inconvenience where tradeoffs really show and demand to study the behavioral/semantic differences.

Funnily enough, I still find Bun interesting.

Regarding import.meta., I already love Vite's dynamic import transpilation features. They aim to work almost transparently and often do (I am not even talking about the glob feature here).

That being said, I'm unsure if Bun's way of bridging the module ecosystem gap using import.meta will be as useful.

If you ask me, frontend code should ban Node/CJS/require entirely or transpile it into static or dynamic ESM imports; respectively.

Any case where this is not possible unambiguously is a case for human intervention and code rewrite/conversion.

Re:Bun v1.0.0 by imbnwa on Saturday September 09, 2023 @02:57AM (#37442899)
>If you ask me, frontend code should ban Node/CJS/require entirely or transpile it into static or dynamic ESM imports; respectively.

>Any case where this is not possible unambiguously is a case for human intervention and code rewrite/conversion.

Good god, yes

Re:Bun v1.0.0 by silverwind on Saturday September 09, 2023 @04:36PM (#37450027)
Why go to such lengths to support a legacy module system?

All three patches mentioned will lead to modules that work only in bun and not work in node/deno/browsers, further fragmentating the ecosystem.

Re:Bun v1.0.0 by The_Colonel on Sunday September 10, 2023 @10:52AM (#37456354)
It's a legacy module system with a lot of code written in it. Without mixed support, you can't rewrite code incrementally to use the ES modules. As a consequence, many projects still stay with CommonJS, since the migrating everythin in one go is a big hurdle.
Re:Bun v1.0.0 by mmcnl on Saturday September 09, 2023 @03:38PM (#37449476)
In a sense, an opinionated collection of tools _is_ a solution.
Re:Bun v1.0.0 by kwhitley on Monday September 11, 2023 @12:34PM (#37469750)
Yeah, definitely recommend you try it before discounting... I too have been super jaded with the current Node import ecosystem (esp. as an author), but Bun has basically become something of a silver bullet, with some small exceptions.

If I want, I can literally run a TS file directly with mixed import/require (not that you would ever) directly, without a package.json, tsconfig, dependencies, etc.

In my experience, it's basically Node, minus all the setup/config/build headaches.