News for hackers. Stuff that matters.
Re:Semantic Code Reviews – Simple and direct comments withou... by orenyk on Monday August 14, 2023 @07:11AM (#37119654)
I've been a big fan of this approach for years (introduced to me by Conventional Comments [1]) - even though it may not always be necessary, it's a low-effort way to make sure you're not misunderstood.

[1] https://conventionalcomments.org/

Re:Semantic Code Reviews – Simple and direct comments withou... by ajanuary on Monday August 14, 2023 @07:41AM (#37119869)
I'd previously tried Conventional Commits but I found the number of labels they suggest too many to keep in my head. The labels in post map well to how I think about comments.
Re:Semantic Code Reviews – Simple and direct comments withou... by duringwork12 on Monday August 14, 2023 @09:37AM (#37120877)
There is a chrome plugin for this that is awesome. I started using it and one of the things i saw is that the amount PR's that I block went down significantly. Because i will classify block or non blocking per issue so don't end deciding at the end based on the amount.

So for example something that has 10 nitpicks I will let it pass because all it tells me is i'm a dick :)

Re:Semantic Code Reviews – Simple and direct comments withou... by baby_souffle on Monday August 14, 2023 @10:33AM (#37121484)
> There is a chrome plugin for this that is awesome

Link?

Re:Semantic Code Reviews – Simple and direct comments withou... by slaughtr on Monday August 14, 2023 @03:59PM (#37126057)
I’ve had great luck with conventional commits by just ignoring half of them. feat, fix, chore, docs - that’s enough to cover a LOT of cases.
Re:Semantic Code Reviews – Simple and direct comments withou... by kmschaal on Monday August 14, 2023 @08:02AM (#37120054)
Thank you for sharing. The example, where the same sentence is presented with different labels, effectively illustrates the essence of the idea.
Re:Semantic Code Reviews – Simple and direct comments withou... by duringwork12 on Monday August 14, 2023 @09:36AM (#37120867)
There is a chrome plugin for this that is awesome
Re:Semantic Code Reviews – Simple and direct comments withou... by avgcorrection on Monday August 14, 2023 @09:56AM (#37121076)
Appreciation: Thanks for pointing out a related project. (This comment was written to adhere to Conventional Message Board Feedback v3.0.0)