Re:Always the Same Warning Signs
by zaptheimpaler on Wednesday June 14, 2023 @10:24AM
(#36326488)
The big takeaway here for me is to make liberal use of the phrase "Shoo, little people! Out of my way!" when they don't approve my code reviews.
[ Parent
| on HN ]
Also, go right ahead and reject the feedback you Simply Do Not Want To Hear!
(I just loved that use of capital letters!)
Re:Always the Same Warning Signs
by throwaway202351 on Wednesday June 14, 2023 @12:03PM
(#36327965)
Sounds like they're not Team Players if they give you feedback you Simply Do Not Want To Hear!
Arrgh, why didn't I.think of that? I just left for vacation with an open code review that should have been easy because some new junior found some issues that I couldn't resolve before packing my suitcase.
Thanks junior, the issues you found were real, even if small, and things will be better when I return and fix them.
Already been doing it for years, implicitely, by making my code as unreadable as possible. But now I can justify it by saying I'm doing Science.
I prefer the less disparaging, "Well, I'm going to check it in anyway" and as a bonus, it doesn't directly acknowledge the existance of other people.
Re:Always the Same Warning Signs
by cratermoon on Wednesday June 14, 2023 @12:05PM
(#36327986)
I had a co-worker who would reject feedback and then complain that it was the reviewers' fault that his PRs weren't merged.