I gave commit rights to someone I didn't know

Re:I gave commit rights to someone I didn't know by globular-toast on Tuesday May 30, 2023 @05:29AM (#36122849)

As if you are reviewing 5k lines, though. It's either 90% whitespace changes that you completely skim over (probably missing the one bit that actually changed) or you just skim over it looking for a few patterns you don't like such as using a loop instead of Array.map or something.

[ Parent | on HN ]

Re:I gave commit rights to someone I didn't know by smabie on Tuesday May 30, 2023 @05:54AM (#36122991)

This is so true.

[ Parent | on HN ]

Re:I gave commit rights to someone I didn't know by sh4rks on Tuesday May 30, 2023 @05:55AM (#36122997)

When they say 5k lines, I'm assuming they mean 5k lines of meaningful code. 5k lines with whitespace changes, linting etc. would be impossible to meaningfully review

[ Parent | on HN ]