Re:JEP 443: Unnamed Patterns and Variables (Preview)
by cosmotic on Tuesday March 21, 2023 @08:58PM
(#35255209)
My $0.02: Unnamed variables just seem to add confusion and inconsistency. Inconsistency like this in Scala and Perl make it harder to learn and offer little value.
Re:JEP 443: Unnamed Patterns and Variables (Preview)
by speed_spread on Tuesday March 21, 2023 @09:35PM
(#35255557)
They allow to give out warnings on unused variables. If the warning is unwarranted and you really want to discard the value, you use _. It helps prevent mistakes by giving a hint on the intent of the programmer.
Re:JEP 443: Unnamed Patterns and Variables (Preview)
by cosmotic on Tuesday March 21, 2023 @11:57PM
(#35256637)
I find it exceptionally rare to want not to use a variable that way, it's usually something you want to make harder to ignore, not easier. In the case you really do want to ignore, there are annotations to prevent the warning.
Re:JEP 443: Unnamed Patterns and Variables (Preview)
by cosmotic on Wednesday March 22, 2023 @02:01PM
(#35264786)
I understand that; the problem is that it makes it so easy to bypass the safety net the warning is intended to provide. For example, not logging an exception; You'd have to be really intentional to block the warning with an actual annotation, but using an underscore would be so easy you'd just fall into a pattern of always commenting those out. It's better to have a line of code screaming "I'm doing something that looks wrong here but really it's okay" instead of "_".
Re:JEP 443: Unnamed Patterns and Variables (Preview)
by kaba0 on Wednesday March 22, 2023 @03:22AM
(#35257864)
It is a contrived example, but the idea/code pattern isn’t — I have written plenty of code where I had to iterate over a collection with a for loop, but didn’t use the exact element.
But obviously for typical usage one should probably just use the stream API.
Re:JEP 443: Unnamed Patterns and Variables (Preview)
by kaba0 on Wednesday March 22, 2023 @03:17AM
(#35257833)
There is type inference, like ` instanceof Point(var x, var y)`.
The real winner here is obviously the used example, `instanceof ColoredPointer(_, var color)`, here every other solution would be plain ugly. The other examples are just there to make the feature intuitive - for example I quite like the `catch (SomeException _)`, making it exact that this exception is deliberately not used up in the catch block.
Re:JEP 443: Unnamed Patterns and Variables (Preview)
by kaba0 on Wednesday March 22, 2023 @03:29AM
(#35257904)
Okay, what about `instanceof ColoredPoint(3DPoint(_, _, _), var color)`? ColoredPoint’s first field now takes some subtype, and you try to handle only the case where it is a 3DPoint. Now you have to explicitly mention that in the pattern, but it’s possibly long and recursive inner patterns have to be named again.
It can quickly get out of hand, so _ is a pretty well-known and widely used approach here in ML-like languages, and its usage causes no harm at all.
Re:JEP 443: Unnamed Patterns and Variables (Preview)
by invalidname on Wednesday March 22, 2023 @03:38AM
(#35257968)
I get that it exists elsewhere and saw it in other languages. I think it looks a bit weird and doesn't convey the intention properly. One of the nice things in Java is that we don't automatically copy ideas from other languages but deliberate on them first.
Personally, I think the instanceof syntax for Records is terrible and you're showing off exactly why. It breaks encapsulation entirely. What we need to do is fix records so they will have more OOP related principles. instanceof is a patch and switch should be an anti-pattern. If records allowed inheritance we could just add polymorphic APIs to them and then write more elegant code without the instanceof's.
Re:JEP 443: Unnamed Patterns and Variables (Preview)
by kaba0 on Wednesday March 22, 2023 @04:03AM
(#35258119)
> One of the nice things in Java is that we don't automatically copy ideas from other languages but deliberate on them first
Sure, but I’m sure it was not an automatic copy, but a well thought-out design by the very competent design team.
> It breaks encapsulation entirely
Records are almost by definition open. They are only the sum[1] of their constituents. They are part of a more data-oriented approach.
Of course the “old” OOP concerns may apply, and there is an escape hatch — one can make a class from a record, and with the coming destructors it won’t need any recompilation, every existing pattern match can work, yet its inner workings can be encapsulated. But this is not the primary purpose for them — they are just plain old data.
EDIT: though now that I thought a bit about it, hopefully with `withers` we get an alternative syntax for pattern matching on records, like `ColoredPoint { point: 3DPoint { x } }`. That way pattern matching won’t be tied to the order of the fields. Surely records don’t change often, but still.
[1] if we are being pedantic, they are the product of their constituents, they are named product types.
Re:JEP 443: Unnamed Patterns and Variables (Preview)
by HiJon89 on Wednesday March 22, 2023 @03:24AM
(#35257875)
A common example is try-with-resources where you don't actually need the resource and are just using it for the closing effect. For example, let's say you have a metrics library that allows you to time code blocks like so:
Another common example is when you are implementing an interface method or overriding a superclass method, and your implementation doesn't need all the arguments. Would be great for the programmer to have a way to express this intent (to the compiler and to the reader)
This JEP would allow stronger static analysis rules like "every declared parameter and variable MUST be used", and _ would serve as the canonical escape hatch for edge cases.
One datapoint: searching our codebase for variables named "ignored" produces >1,000 hits. And probably an order of magnitude more unused variables that aren't named ignored.
> Another common example is when you are implementing an interface method or overriding a superclass method
This doesn't seem to be supported and could cause many issues e.g. if a base interface adds an overloaded method with a similar signature. Suddenly we will have a conflict and compilation issues.
> This JEP would allow stronger static analysis rules like "every declared parameter and variable MUST be used", and _ would serve as the canonical escape hatch for edge cases.
This is a good point. I'm not sure if it's worth the odd syntax and potential misuse but it is interesting.
Re:JEP 443: Unnamed Patterns and Variables (Preview)
by HiJon89 on Wednesday March 22, 2023 @06:05AM
(#35258922)
> > Another common example is when you are implementing an interface method or overriding a superclass method
> This doesn't seem to be supported and could cause many issues e.g. if a base interface adds an overloaded method with a similar signature. Suddenly we will have a conflict and compilation issues.
I think this is already a risk when modifying interfaces or superclasses. For example, if you add a method to a superclass, a subclass might already have a method with the same name/arguments but different return type, which would break compilation.
Re:JEP 443: Unnamed Patterns and Variables (Preview)
by pdevr on Wednesday March 22, 2023 @03:26AM
(#35257887)
Yes, some of the examples are weak. However, the case of unused variables is a well-known problem. Caught but unused exceptions is one common use case, and they have some code snippets of that in there too. Using _ is a neat solution.
For those who don't face that issue, life continues as before.
If a student handed in a pattern matching system that didn't have a "null variable" pattern, I would not award full marks. That's just useless beyond words; you can't do things like
(match (@a @nil @nil @c) ...)
to match a four-element list, capturing the first and last element; you have to name the variables and then tell your compiler they are deliberately not used.
That seems like a very contrived example. I don't work with Java regularly, but wouldn't that be better written as something like this?
But obviously for typical usage one should probably just use the stream API.
Is it related to anything more useful?
To pattern matching.
var _ = q.remove();
This is just stupid. We can write: q.remove();
We don't need to save the return value in Java. The only case where this makes sense is:
instanceof Point(_, int y)
But that makes sense because the original code is so bad. A better solution would be type inference like we have in lambdas:
instanceof Point(x, y)
If that method returns, many tools will complain that the returned value is ignored
In the case of delete() you would want to check the result. So the warning is good and using an underscore to ignore it would actually be a problem.
In the case of remove() we don't really need the result.
The real winner here is obviously the used example, `instanceof ColoredPointer(_, var color)`, here every other solution would be plain ugly. The other examples are just there to make the feature intuitive - for example I quite like the `catch (SomeException _)`, making it exact that this exception is deliberately not used up in the catch block.
instanceof ColoredPointer(x, color)
is even shorter and it's really not hard to come up with a variable name. In this case some tools might mark x as unused but that's just nonsense.
The catch example is interesting but how often do you completely ignore the exception and should you ever do that?
Is that behavior the language should encourage?
I feel that this is a solution to a very minor inconvenience that is pretty redundant.
It can quickly get out of hand, so _ is a pretty well-known and widely used approach here in ML-like languages, and its usage causes no harm at all.
Personally, I think the instanceof syntax for Records is terrible and you're showing off exactly why. It breaks encapsulation entirely. What we need to do is fix records so they will have more OOP related principles. instanceof is a patch and switch should be an anti-pattern. If records allowed inheritance we could just add polymorphic APIs to them and then write more elegant code without the instanceof's.
Sure, but I’m sure it was not an automatic copy, but a well thought-out design by the very competent design team.
> It breaks encapsulation entirely
Records are almost by definition open. They are only the sum[1] of their constituents. They are part of a more data-oriented approach.
Of course the “old” OOP concerns may apply, and there is an escape hatch — one can make a class from a record, and with the coming destructors it won’t need any recompilation, every existing pattern match can work, yet its inner workings can be encapsulated. But this is not the primary purpose for them — they are just plain old data.
EDIT: though now that I thought a bit about it, hopefully with `withers` we get an alternative syntax for pattern matching on records, like `ColoredPoint { point: 3DPoint { x } }`. That way pattern matching won’t be tied to the order of the fields. Surely records don’t change often, but still.
[1] if we are being pedantic, they are the product of their constituents, they are named product types.
This JEP would allow stronger static analysis rules like "every declared parameter and variable MUST be used", and _ would serve as the canonical escape hatch for edge cases.
One datapoint: searching our codebase for variables named "ignored" produces >1,000 hits. And probably an order of magnitude more unused variables that aren't named ignored.
This doesn't seem to be supported and could cause many issues e.g. if a base interface adds an overloaded method with a similar signature. Suddenly we will have a conflict and compilation issues.
> This JEP would allow stronger static analysis rules like "every declared parameter and variable MUST be used", and _ would serve as the canonical escape hatch for edge cases.
This is a good point. I'm not sure if it's worth the odd syntax and potential misuse but it is interesting.
> This doesn't seem to be supported and could cause many issues e.g. if a base interface adds an overloaded method with a similar signature. Suddenly we will have a conflict and compilation issues.
I think this is already a risk when modifying interfaces or superclasses. For example, if you add a method to a superclass, a subclass might already have a method with the same name/arguments but different return type, which would break compilation.
For those who don't face that issue, life continues as before.
https://www.kylheku.com/cgit/txr/tree/stdlib/match.tl
If a student handed in a pattern matching system that didn't have a "null variable" pattern, I would not award full marks. That's just useless beyond words; you can't do things like
to match a four-element list, capturing the first and last element; you have to name the variables and then tell your compiler they are deliberately not used.23 is the error block: run-time function sys:match-pat-error is called with some arguments, like D3, which holds the source code of the pattern.
Not reached, since that function throws: