News for hackers. Stuff that matters.
Re:My experience shadowing an Engineering Director for a week by astrange on Monday March 06, 2023 @02:47AM (#35038479)
> He added me to a Slack channel where he would share the topics, issues, and Merge Requests(MR) he is working on.

How many PRs a week does a director work on there? Seems unusual to have any.

Re:My experience shadowing an Engineering Director for a week by londons_explore on Monday March 06, 2023 @03:35AM (#35038778)
In a similar position, I don't write much code anymore, but I review a lot.

I don't do the 'you should have made this const' or 'this variable is badly named' type of review... But I do a higher level check that nobody is overcomplicating simple things and building 37 new microservices when they ought to just be using one that already exists.

Overcomplicating simple things is a really common way to justify growing your team, getting a promotion, etc.

Suddenly the 'internal printer management team' needs 8 developers, dedicated network bandwidth, and a project roadmap multiple years out with shiny webUI's, when all we really needed was a couple of dumb printers and 0.1 people to manage them.

Re:My experience shadowing an Engineering Director for a week by fathyb on Monday March 06, 2023 @04:40AM (#35039157)
I feel this is something that should be caught during the design phase, not during the development phase. I expect top-level management to sign-off design and requirement documents, not pull requests.
Re:My experience shadowing an Engineering Director for a week by trallnag on Monday March 06, 2023 @07:02AM (#35040012)
What's the size of your company?
Re:My experience shadowing an Engineering Director for a week by waynesoftware on Monday March 06, 2023 @08:29AM (#35040690)
GitLab team member here (the one who was shadowed). Most of my merge requests were for the engineering portions of the company handbook.