News for hackers. Stuff that matters.
Re:Will Carbon Replace C++? by hot_gril on Tuesday February 28, 2023 @12:42AM (#34966064)
Our style guide says "almost never auto," but most people auto everything. They can make the linter replace auto with the actual type if it's really that big a deal. Explicit type wouldn't have avoided this bug.
Re:Will Carbon Replace C++? by LaLaLand122 on Tuesday February 28, 2023 @01:03AM (#34966202)
Arguably an explicit type would have made the bug a little bit more obvious. You basically expect, by default, this kind of string manipulation functions to return a std::string. Obviously in this specific case you can return a view, and that makes it more performant; but it's kind of unexpected and using auto leaves the surprise a bit more hidden.

But sure, you can still make the error with expiclit types.

Re:Will Carbon Replace C++? by hot_gril on Tuesday February 28, 2023 @02:03AM (#34966485)
I agree, the string_view on the LHS might make you think more about the lifetime, but I'm pretty sure we all would've missed it.