Re:WordPlate: WordPress on Composer with sensible defaults
by 9dev on Sunday February 26, 2023 @05:43AM
(#34944562)
Read this article for a primer on why PDO is a vastly better choice: https://phpdelusions.net/pdo#why
And the fact that it’s 2023 and we’re somehow ok with the biggest web application there is not using parametrised queries in its core completely stumps me. Time and time again, SQL injection attacks in Wordpress or it’s plugins pop up. PDO with parametrised queries simply eliminates this issue.
Re:WordPlate: WordPress on Composer with sensible defaults
by luckylion on Sunday February 26, 2023 @06:17AM
(#34944692)
> PDO with parametrised queries simply eliminates this issue.
True, but plugin authors not caring about using them is the primary issue, and that doesn't change just because wpdb uses a different API under the hood.
Re:WordPlate: WordPress on Composer with sensible defaults
by 9dev on Sunday February 26, 2023 @07:08AM
(#34944910)
No, but nobody will encourage them to. Wordpress has fostered an ecosystem of bad practices that is mostly resistant to change.
Re:WordPlate: WordPress on Composer with sensible defaults
by tyingq on Sunday February 26, 2023 @06:36AM
(#34944768)
>Also $wpdb->prepare() uses parametrised values.
They appear to be a hand-rolled PHP version of imitation parameterized values, not the actual database library ones.
https://github.com/WordPress/WordPress/blob/master/wp-includ...
Re:WordPlate: WordPress on Composer with sensible defaults
by berkle4455 on Sunday February 26, 2023 @11:08AM
(#34946564)
Wow. That is so much code just to avoid calling mysqli_prepare(). And they insist on using a weird printf inspired syntax instead of ? or :field.
Also $wpdb->prepare() uses parametrised values. Not everywhere in WordPress core is it being used. Most plugins use it for direct queries (not that common), but I don't know if the plugin team refuses plugins when they are not using it.