News for hackers. Stuff that matters.

A comment on Don’t Teach During Code Reviews. Parent comment

Re:Don’t Teach During Code Reviews by Aeolun on Sunday February 05, 2023 @07:59PM (#34671834)
To be fair, some people are just pedantic. Just because you are the reviewer doesn’t mean things have to be done exactly the way you say.

If I never accept anything from more junior people because it isn’t perfect, how are they ever going to stay motivated?

I aim for one or at most two rounds of review, because anything else is just depressing.

[ Parent | on HN ]
Re:Don’t Teach During Code Reviews by cramjabsyn on Sunday February 05, 2023 @09:40PM (#34672608)
Ehhh far from perfection, more like “please use the native feature that handles this in 2 LOC instead of shelling out to an external 100 line script”
[ Parent | on HN ]
Re:Don’t Teach During Code Reviews by Aeolun on Monday February 06, 2023 @10:24PM (#34688341)
There’s limits and degrees to anything. I guess I never get PR’s that are quite that boneheaded.
[ Parent | on HN ]
Re:Don’t Teach During Code Reviews by interactivecode on Monday February 06, 2023 @03:20AM (#34674701)
100% agree, code review should be there to check if the code doesn’t contain any obvious security risks or mistakes.

Designing features, architecture and learning should happen before someone even gets to the point of submitting a PR. Plus if it can be improved on in follow PRs then do that instead of blocking juniors with pedantics

[ Parent | on HN ]