Re:Don't return null; use a tail call
by politician on Tuesday January 10, 2012 @03:32PM
(#3448868)
I'm not bashing your idea, but throwing an authentication exception covers this almost entirely.
See, the calling code probably can't correctly proceed unless authentication was successful, and there's no chance that the caller can simply forget to handle an exception -- at the very least, it'll hit a top-level exception handler and/or crash the program.
That is another viable strategy if you don't want to handle the login failure in any graceful way.
Re:Don't return null; use a tail call
by politician on Wednesday January 11, 2012 @10:59AM
(#3452234)
Exceptions are not a crash-or-nothing proposition. The idea is that the caller should handle them at the earliest point in the call-stack that can do something reasonable about the problem.
Also, let me clarify that I don't believe that exceptions should be used as the only way to return values from a method in languages that support them. They are simply a tool with certain properties (among them, the ability to be more difficult to ignore, the topic at hand).
I generally find that one should avoid using exceptions for flow control. They have their usages, but they should in my opinion only be used when they really shine - when you have multiple levels of callers between the detection of the error and the handling. This was not the case in the simple example, and so I chose a return value instead of an exception.
Instead of using a callback method, why not just return an instance of some more sophisticated class, i.e something like this:
with a possible usage: If the client then tries to use a failed AuthenticationResult as a successful one, or use a successful AuthenticationResult as a failed one, the programmer is free to throw any informative exception. Example: If one instead would use 'null' as a magic value for 'auth failed', the dreaded NPE would show up instead!