News for hackers. Stuff that matters.
Re:We invested 10% to pay back tech debt; Here's what happened by neilv on Sunday January 15, 2023 @07:17PM (#34395170)
I've also seen this sprint-task-fake-completed later cleanup misattributed to "refactoring", which I've started calling "fudge-factoring".

IMHO, at the point you have engineers misrepresenting that something is done, even if you're not in an application domain in which engineers go to jail for that, you take a step back and fix your engineering/product culture.

That might include nuking your current methodology from orbit, just to reinforce that organization needs to learn a new way of thinking. (Not just "don't do that" on one symptom, when whatever culture weakness that caused the fudging is still in play.)

Re:We invested 10% to pay back tech debt; Here's what happened by josephg on Sunday January 15, 2023 @07:42PM (#34395349)
Yep. Or in other words, you (usually) can’t solve cultural problems with technical solutions. If your team culture doesn’t value long term thinking, it’ll take more than a schedule change to introduce that mentality.

In the story in this post, one important thing that happened was that the team (with management) came together to acknowledge the tech debt problem, acknowledge they want to solve it and talk through potential solutions. This moves the problem from something individuals care about to something the team as a whole acknowledges it care about (a shift from individual knowledge to common knowledge). Once everyone agrees this is a problem, individual engineers will know they’re acting against the will of the tribe by writing lazy pull requests. And being reprimanded by their coworkers for doing so will have much more weight.

Re:We invested 10% to pay back tech debt; Here's what happened by eru on Sunday January 15, 2023 @09:05PM (#34395953)
> Or in other words, you (usually) can’t solve cultural problems with technical solutions.

Yes, though technical solutions go a long way towards making cultural solutions work and stick.

Eg running your tests automatically when someone makes a Pull Request is much more robust, even in a cultural sense, than asking developers to manually run the tests.

Technical solutions can help make the culturally favoured approach also be the path-of-least resistance.

Of course, you still have to write the tests. (Though even there, you can make your technical tools check for eg test coverage. That can be gamed, but that's more effort than when you can just ignore it; and even gamed coverage is better than no coverage.)

Re:We invested 10% to pay back tech debt; Here's what happened by hgsgm on Sunday January 15, 2023 @09:19PM (#34396039)
"Locks on doors keep honest people honest". Same goes for rules in an organization. It gives people an excuse to do the right thing.
Re:We invested 10% to pay back tech debt; Here's what happened by josephg on Sunday January 15, 2023 @09:54PM (#34396274)
True; but you're going to get much better testing if your team collectively cares about it than if it feels externally mandated by that one annoying guy who set up your commit rules.

Technical solutions are the best solutions when they work. But being technologists will bias us towards looking for technological ways to solve problems. Its not always the best approach. A few hours chatting over lunch is usually a much more effective way to change how your team works.

Re:We invested 10% to pay back tech debt; Here's what happened by wpietri on Sunday January 15, 2023 @11:39PM (#34396866)
> True; but you're going to get much better testing if your team collectively cares about it than if it feels externally mandated by that one annoying guy who set up your commit rules.

Some of the worst tests I've ever seen were in places where managers measured test coverage. Reams and reams of absolutely useless tests that may not have checked anything that mattered, but that did bump the coverage metric up.

Re:We invested 10% to pay back tech debt; Here's what happened by quanticle on Monday January 16, 2023 @01:50AM (#34397650)

    Reams and reams of absolutely useless tests that may not have
    checked anything that mattered, but that did bump the coverage
    metric up.
I would go farther than that, and call those tests worse than useless. Tests that are written to appease some kind of automated coverage metric god tend to be tests that test internal implementations rather than API contracts. So you end up with a codebase where a single line change to production code requires something like 150 lines of test code changes, all because the internal representation of some data was changed in some kind of trivial way.

It's possible to avoid this failure mode, but the teams that are smart enough to avoid this failure mode are also generally smart enough to avoid having unreasonable coverage goals.

Re:We invested 10% to pay back tech debt; Here's what happened by F-W-M on Monday January 16, 2023 @06:52AM (#34399715)
I once found

``` if (var) assert(var) else assert(!var) ```

in the outsourced test suite for a level A air plane software.

Re:We invested 10% to pay back tech debt; Here's what happened by eru on Monday January 16, 2023 @01:05AM (#34397368)
Agreed. I am suggesting that the technical environment can make certain cultures mores easier or harder to do.

Cultural change is hard enough, so getting as many of the technical nudges as you can, is good.

Re:We invested 10% to pay back tech debt; Here's what happened by Retric on Sunday January 15, 2023 @08:23PM (#34395666)
I think it’s less an engineering culture issue than a management one. Do you reward people based on number of features, meeting rapid deadlines, quality, or something else like customer satisfaction?

People respond to an organizations actual priorities not whatever platitudes people toss out. If you want quality you need to sacrifice something even if long term results improve in the short term quality takes time.

Re:We invested 10% to pay back tech debt; Here's what happened by wpietri on Sunday January 15, 2023 @11:37PM (#34396852)
Exactly. I recall one place where an exec pushed for something to be completed in a too-short timeframe. It launched on the schedule he announced to his higher-ups, so he was promoted and moved elsewhere. Woe be to the exec who inherited the project, though, as the code was basically a mound of turds wrapped in Christmas paper. And the team, of course, was fractured and burnt out. The cherry on top was watching the ladder-climber throw a lunch to thank the team; their reward for hundreds of hours of grueling overtime was lukewarm Chinese food dished out of large aluminum bins in a conference room. Plus $50 gift cards!

This was a long time ago, but I still think about it as a moment when I learned what POSIWID really meant.

Re:We invested 10% to pay back tech debt; Here's what happened by tjrDL6MjB2Zwwa on Monday January 16, 2023 @06:34PM (#34407040)
heh, what is POSIWID?
Re:We invested 10% to pay back tech debt; Here's what happened by wpietri on Monday January 16, 2023 @09:28PM (#34408458)
Re:We invested 10% to pay back tech debt; Here's what happened by hiddencost on Sunday January 15, 2023 @08:47PM (#34395825)
I've watched a really elite group of engineers fall apart slowly because one leader decided to start committing systematic fraud and coaching his delegates to commit fraud.

It's well done, because it's almost impossible to prove.

Those of us who still care about system health and helping users just wait two years after they launch something, ask leadership for permission to delete it, and keep trying to build abstractions that reduce the harm misconduct has on our parts of the system.

The problem is they keep getting promoted because no one notices that almost nothing they've built is still in production.

A few of us have tried raising the issue to leadership but no one in leadership wants to know. It's a bit spooky. My current theory is that no one has the power to deal with it anymore, and at higher levels, launching garbage features that get deleted is actually desirable.

Theory: senior leadership keeps saying "drop what you're doing and build X". This group does that, but in a way that's half baked enough that we can kill it later. Middle management benefits because senior leadership is happy, and deleting it is fine because leadership forgot about it.

I wish I knew a way out.

Re:We invested 10% to pay back tech debt; Here's what happened by mansoon on Sunday January 15, 2023 @08:54PM (#34395885)
Leetcode
Re:We invested 10% to pay back tech debt; Here's what happened by neilv on Sunday January 15, 2023 @09:05PM (#34395955)
Leetcode, meaning here to switch jobs?

A little ironic, because Leetcode interviews arguably send the message that the org is about nonsense hoop-jumping and politics.

Re:We invested 10% to pay back tech debt; Here's what happened by zeroonetwothree on Sunday January 15, 2023 @10:39PM (#34396521)
Leetcode seems like the opposite of politics at least. Hoop jumping sure.
Re:We invested 10% to pay back tech debt; Here's what happened by sidlls on Sunday January 15, 2023 @11:05PM (#34396663)
It's a signal of politics, too: at companies where the people who view that kind of hoop jumping as an important signal got their way, it means they won that political battle.
Re:We invested 10% to pay back tech debt; Here's what happened by sebzim4500 on Monday January 16, 2023 @08:36AM (#34400464)
I don't get what you mean. Couldn't you equally claim that in companies that avoid leetcode interviews the anti-leetcode people won that political battle. I don't see why one option is more political than the other.
Re:We invested 10% to pay back tech debt; Here's what happened by sidlls on Monday January 16, 2023 @01:00PM (#34403495)
You're right, of course: the politics works both ways here.
Re:We invested 10% to pay back tech debt; Here's what happened by gymbeaux on Monday January 16, 2023 @03:46PM (#34405274)
I’m sure the topic of leetcode has been beaten to death on a forum such as this, but serious question: with ChatGPT, why WOULDNT I cheat, assuming the leetcode is the unmonitored/unproctored variety (most are this way)? Like seriously. We know the leetcode skill isn’t applicable to the actual duties and responsibilities of the job itself, so why not cheat, especially when ChatGPT makes it so easy?
Re:We invested 10% to pay back tech debt; Here's what happened by raincom on Sunday January 15, 2023 @10:21PM (#34396424)
If organizational goals are centered about building X with half-baked features and then kill it after the perf review cycle, it is rational for everyone to focus on that. Stop wasting time on fixing tech debt. There is always a main product that pays all salaries and bonuses. As organization gets larger, fiefdoms get built by hiring more people. Just understand what’s going on and use that “knowledge” to advance careers and to make more money.
Re:We invested 10% to pay back tech debt; Here's what happened by karmakaze on Sunday January 15, 2023 @10:32PM (#34396485)
I have a knee-jerk reaction when most people say "refactoring". In many cases they're talking about a different, arbitrary way to deduplicate an implementation, usually in a mindless/mechanical way. If you can't name the 'factor' that you're separating and that factor doesn't have business or conceptual cohesiveness, then you're just pushing bits around for someone else to want to do it differently. So now when someone says it, I always ask what do you propose to factor and why?
Re:We invested 10% to pay back tech debt; Here's what happened by rileymat2 on Monday January 16, 2023 @12:28AM (#34397153)
> usually in a mindless/mechanical way

Loaded language not withstanding one of the premier books is all about “mindless/mechanical” changes to structure without changing behavior. It is about step by step safe microchanges.

This might be the biggest difference between refactoring and rewriting.

But you are right it is pushing bits around with no behavioral change. That’s the point.

The open question is if this newly refactored software is more maintainable, more understandable, easier to change in the dimensions it will mutate in the future. Often the answer is “no” and you are right to be frustrated.

Re:We invested 10% to pay back tech debt; Here's what happened by karmakaze on Monday January 16, 2023 @12:50AM (#34397284)
The execution (how) can be 'mechanical' but the goals and choices (why) should be thoughtful. If it's simply deduplication there is no thoughtful why necessary, although in the worst cases abstract machinery is created for the purpose.

You're right about my misconstruing 'no behaviorial change' as that is always a requirement. There should however be a change in where the seams of the implementation lie which better suits the direction of expected changes.

Re:We invested 10% to pay back tech debt; Here's what happened by escapedmoose on Sunday January 15, 2023 @10:36PM (#34396509)
When the team has gone that far off the edge, imo it’s good when the wheels start falling off, when tickets start piling up, when the dev team very visibly has egg on its face. Sometimes it takes until the team is embarrassed before management embraces the option to go nuclear on the dev methodology. But I don’t know how to ensure that it’s the poisonous methodology that’s targeted and not individual people/scapegoats.
Re:We invested 10% to pay back tech debt; Here's what happened by switch007 on Monday January 16, 2023 @04:46AM (#34398766)
> I've also seen this sprint-task-fake-completed later cleanup misattributed to "refactoring", which I've started calling "fudge-factoring".

Having just spent a week clearing up and properly implementing my colleagues' 'fake completed' sprint tasks, I can resonate deeply. I'm making it clear to my boss that it wasn't 'refactoring', I was just implementing the actual requirements properly.

I'm going to go over their next PR with a fine-tooth comb, no matter how long it takes