News for hackers. Stuff that matters.
Re:I found a bug in SQLite by TAForObvReasons on Sunday December 11, 2022 @08:34PM (#33949798)
There was an interesting comment a few months ago [1]

> Not mentioned is that the full test sqlite test suite is proprietary and you need a super expensive sqlite foundation membership to get access to it.

According to Dr Hipp [2], no one bought the test suite. So there are definitely deficiencies in the test suite which may have been better addressed if the full test suite was open.

[1] https://news.ycombinator.com/item?id=33346661

[2] https://corecursive.com/066-sqlite-with-richard-hipp/#billio...

Re:I found a bug in SQLite by notRobot on Sunday December 11, 2022 @11:09PM (#33950763)
From the second link:

> We still maintain the first one, the TCL tests. They’re still maintained. They’re still out there in the public. They’re part of the source tree. Anybody can download the source code and run my test and run all those. They don’t provide 100% test coverage but they do test all the features very thoroughly. The 100% MCD tests, that’s called TH3. That’s proprietary. I had the idea that we would sell those tests to avionics manufacturers and make money that way. We’ve sold exactly zero copies of that so that didn’t really work out. It did work out really well for us in that it keeps our product really solid and it enables us to turn around new features and new bug fixes very fast.

Re:I found a bug in SQLite by ec109685 on Monday December 12, 2022 @12:40AM (#33951295)
It also makes forking SQLite infeasible since any new changes will be woefully under tested.
Re:I found a bug in SQLite by morelisp on Monday December 12, 2022 @02:40AM (#33951991)
SQLite's free test suite is far in excess of most other projects'. What do you think the test coverage is in the Linux kernel, GCC, or Emacs?
Re:I found a bug in SQLite by ec109685 on Monday December 12, 2022 @12:20PM (#33957354)
Right, but it makes the fork strictly worse from a reliability perspective than SQLite given it will be less tested.

If there wasn't a competitive advantage given it has no sales, wouldn't they have open sourced it by now?

Re:I found a bug in SQLite by morelisp on Monday December 12, 2022 @01:36PM (#33958360)
> wouldn't they have open sourced it by now?

If there's minimal value in it, why put in the work to open source an extremely complex test environment?

Re:I found a bug in SQLite by ec109685 on Monday December 12, 2022 @03:31PM (#33959831)
Just for completeness sake, they do offer a SQLite Consortium Membership for $120k, which I guess includes all their test suites as a selling point: https://www.sqlite.org/prosupport.html
Re:I found a bug in SQLite by The_Colonel on Monday December 12, 2022 @02:57AM (#33952098)
(Embedded) database has stricter requirements than a text editor or a compiler.
Re:I found a bug in SQLite by morelisp on Monday December 12, 2022 @03:11AM (#33952185)
Obviously not, if nobody was willing to buy the test suite for their internal forks.
Re:I found a bug in SQLite by The_Colonel on Monday December 12, 2022 @03:22AM (#33952252)
That's a non-sequitur argument.
Re:I found a bug in SQLite by morelisp on Monday December 12, 2022 @11:23AM (#33956496)
It follows fine, but you want to debate instead of think.

If the 100% MC/DC coverage was critical to forks, the companies that fork (there's lots of them!) would have bought it.

Nobody bought it, so it's not that important to maintaining a fork compared to the regular test suite even for such environments. A test suite which, to go back to my first comment, is still leagues ahead of the dozen other pieces of lynchpin software most companies have no problem depending on.

Meanwhile, for the 99.9% of us out here not building aircraft and merely shipping a billion browsers or phones...

Re:I found a bug in SQLite by The_Colonel on Monday December 12, 2022 @12:13PM (#33957249)
> If the 100% MC/DC coverage was critical to forks, the companies that fork (there's lots of them!) would have bought it.

Again, that's a non-sequitur (or perhaps strawman, you can choose), because I wasn't addressing the proprietary test set, merely the comparison between a text editor and a database, which is completely absurd since the tolerance for failures is drastically different.

Re:I found a bug in SQLite by morelisp on Monday December 12, 2022 @01:34PM (#33958330)
> I wasn't addressing the proprietary test set

Then perhaps you're in the wrong thread to be saying anything at all.

Re:I found a bug in SQLite by bigDinosaur on Monday December 12, 2022 @07:39AM (#33954034)
What was the incentive to buy these tests if they've already been used to improve the product?
Re:I found a bug in SQLite by bluGill on Monday December 12, 2022 @09:41AM (#33955088)
You can then audit the tests to ensure they test some condition that you are concerned about.

In reality nobody audits source code like that (see heartbleed for an unrelated example of critical code that didn't get proper audits from people who should have cared)

Re:I found a bug in SQLite by cryptonector on Monday December 12, 2022 @12:23PM (#33957393)
But the testsuite being proprietary is part of their business model.