News for hackers. Stuff that matters.
Re:Falsehoods programmers believe about undefined behavior by account42 on Monday November 28, 2022 @10:02AM (#33774445)
> For example, `if (fermats_last_theorem_is_wrong()) {*p == 1} ` will imply to a modern compiler that p is not NULL in the scope where it is defined, even if we now know that this code will never be reached (assuming that function is correctly written).

No it won't. Otherwise all precondition checks would be meaningless. The compiler can only assume that it isn't null when fermats_last_theorem_is_wrong() is true. If the compiler cannot reason about fermats_last_theorem_is_wrong() then it can't just ignore it.

> for(int i=0; i > n;) { } *p=1;

> Here the compiler will assume that the loop terminates, since non-terminating loops without side-effects are UB in C++.

Infinite loops are UB precisely because otherwise the compiler would NOT be able to reason about this. So yes, here the comiler can assume that p is a valid pointer - but only because it can also assume that *p=1 is NOT dead. This falls entirely under the umbrella of behavior not being defined at all after you execute undefined behavior (the infinite loop).

> This remains valid even if you call this function with an n such that *p=1 is unreachable.

Only because the loop itself is undefined behavior in that case.

Re:Falsehoods programmers believe about undefined behavior by AstralStorm on Monday November 28, 2022 @10:26AM (#33774747)
That is not an infinite loop, it has an exit condition on i > n.

An infinite loop is not UB. It is well defined. Just the definition of a terminating loop is a bit funny.

> An iteration statement whose controlling expression is not a constant expression, that performs no input/output operations, does not access volatile objects, and performs no synchronization or atomic operations in its body, controlling expression, or (in the case of a for statement) its expression, may be assumed by the implementation to terminate.

Plus:

> An omitted controlling expression is replaced by a nonzero constant, which is a constant expression.

The compiler may only use as-if rule here if it can deduce the value is constant or limited. It can (but does not have to) assume the loop will end due to the conditional and lack of the other features. Which is still defined behavior. (since C11 at least, probably earlier)

Re:Falsehoods programmers believe about undefined behavior by haberman on Monday November 28, 2022 @10:44AM (#33774973)
> An infinite loop is not UB. It is well defined.

From C11:

> An iteration statement whose controlling expression is not a constant expression,156) that performs no input/output operations, does not access volatile objects, and performs no synchronization or atomic operations in its body, controlling expression, or (in the case of a for statement) its expression-3, may be assumed by the implementation to terminate.157)

> 157)This is intended to allow compiler transformations such as removal of empty loops even when termination cannot be proven.

This makes infinite loops UB unless they fall under one of these exceptions (constant controlling expression, performs I/O, accesses volatile objects or atomics).

Re:Falsehoods programmers believe about undefined behavior by AstralStorm on Monday November 28, 2022 @12:43PM (#33776726)
Not particularly. It does not allow the compiler to assume true infinite loops can terminate.

It only allows the compiler to assume loops with non-constant expressions can terminate. (And a bunch of other exceptions where it cannot.) A true infinite loop has a constant expression as the conditional and cannot be optimized away based on this rule.

What this rule allows the compiler to do is to optimize away loops where number of iterations are known ahead of time if it has a non-constant expression condition.

Re:Falsehoods programmers believe about undefined behavior by haberman on Monday November 28, 2022 @02:08PM (#33778062)
> It only allows the compiler to assume loops with non-constant expressions can terminate. (And a bunch of other exceptions where it cannot.)

That is basically what I said: loops can be assumed to terminate, except for an enumerated set of exceptions where infinite loops are allowed.

You seem to be defining "true infinite loop" to mean "while(1)" or "for(;;)" exclusively. But "for (int i = 0; i < 1;)" is also an infinite loop, and that one is UB since the controlling expression is not constant.

> What this rule allows the compiler to do is to optimize away loops where number of iterations are known ahead of time if it has a non-constant expression condition.

If the number of iterations are known ahead of time, then it is not an infinite loop so I don't see how the rule would apply.

The rationale for making infinite loops UB is described here: https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1528.htm

Specifically, it allows for transformations like turning:

    for (p = q; p != 0; p = p -> next) {
        ++count;
    }
    for (p = q; p != 0; p = p -> next) {
        ++count2;
    }
into:

    for (p = q; p != 0; p = p -> next) {
            ++count;
            ++count2;
    }
Re:Falsehoods programmers believe about undefined behavior by AstralStorm on Monday November 28, 2022 @05:06PM (#33780545)
Infinite loop with a constant expression is defined behavior.

for (;;) { }; cannot be assumed to have finite number of executions. Therefore, it cannot be optimized away to finite execution.

You're showing potentially infinite loops with non-constant expression as condition.

for (; i != 0; ) {} can be assumed to have finite number of executions and can be optimized unless i is constant expression.

Re:Falsehoods programmers believe about undefined behavior by haberman on Tuesday November 29, 2022 @11:53AM (#33789977)
> Infinite loop with a constant expression is defined behavior.

Yes, because a constant controlling expression is one of the enumerated exceptions to the rule against infinite loops.

> You're showing potentially infinite loops with non-constant expression as condition.

"for (int i = 0; i < 1;)" is an infinite loop, full stop. It is not potentially infinite, it is infinite under all possible executions. It is UB because it does not fall under one of the enumerated exceptions where an infinite loop is allowed.

I think we are saying the same thing, the only difference is that you seem to be defining "infinite loop" to only include loops with constant controlling expressions, whereas I am defining it to mean "any loop that does not terminate."

Re:Falsehoods programmers believe about undefined behavior by tsimionescu on Tuesday November 29, 2022 @03:38AM (#33785091)
Yes, the part about Fermat's last theorem I wrote is actually obviously wrong, I don't know what exactly I was thinking when I wrote it.

The example with the loop though is more to point out that our native understanding of "unreachable" may be different than the compiler's. The same problem could occur without invoking UB if we un-conditionally generate a SIGKILL to our own process and then dereference a NULL pointer - the compiler doesn't know what SIGKILL does, so it doesn't know the UB is unreachable in practice, so it may reorder etc.

Re:Falsehoods programmers believe about undefined behavior by gpderetta on Tuesday November 29, 2022 @05:59AM (#33786030)
> the compiler doesn't know what SIGKILL does, so it doesn't know the UB is unreachable in practice, so it may reorder etc

It is the reverse. If the compiler doesn't know what raise(SIGKILL) (or really, any other function it cannot see through) does, it has to assume that it can potentially never terminate, abort or otherwise change the control flow, so it can't safely reorder across it. And even if it does return, it could still inspect memory and observer the violation of the as-if rule.

That's why for example pthread_mutex_lock/unlock worked correctly for the most part even before C++ got a proper concurrent memory model.