Re:Gamification Affects Software Developers: Cautionary Evid...
by nuc1e0n on Monday October 24, 2022 @06:13AM
(#33314761)
I would say this is never healthy, even for a team of 2 people. These days merging code without at least asking for a review should be anathema for devs. Even a 'rubber stamping' review at least signifies a shared awareness of changes.
Re:Gamification Affects Software Developers: Cautionary Evid...
by NoahTheDuke on Monday October 24, 2022 @08:09AM
(#33315648)
Other workflows exist; pretty silly to act like you’ve found the One True Way.
Re:Gamification Affects Software Developers: Cautionary Evid...
by nuc1e0n on Monday October 24, 2022 @04:48PM
(#33322505)
If you don't care about code reviews, why care about a PR process? don't protect the branch and just make your commits. The notion of a pull request is you're requesting someone pull in your changes. But you don't want them to review those changes?!
Re:Gamification Affects Software Developers: Cautionary Evid...
by pferde on Monday October 24, 2022 @06:13AM
(#33314762)
Yes, you can get that badge safely only if you adjust your project's development flow.
This exactly proves the central point of the article - gamification affects software developers.
Re:Gamification Affects Software Developers: Cautionary Evid...
by belmont_sup on Monday October 24, 2022 @08:08AM
(#33315641)
Viewed from a different lens, these achievements seem intended for new GitHub users.
I recall merging my OWN pr into my own new repo. I was surprised with a badge. No harm in that.
There's a case where this is not just ok, but healthy (especially on smaller teams) - if you're comfortable doing trunk-based development then you can use a PR to "snapshot" a set of changes and either invite commentary or just have a link to share as an FYI around the change, without the awkwardness of linking to an unnamed commit sequence.
https://martinfowler.com/articles/ship-show-ask.html