Re:Linus: please write good git commit messages
by tl on Sunday November 27, 2011 @12:46PM
(#3282865)
Be careful, we do that by default and we get a lot of "commit", "commit", "commit $date", "merge commit" messages from some programmers. Either a programmer accepts that a meaningful message is important on commits, or they don't. It's a people problem not a technical one.
Re:Linus: please write good git commit messages
by tomjen3 on Sunday November 27, 2011 @03:20PM
(#3283290)
The problem with that is that at least when I am merging something I often (with Mercurial anyway) don't have anything useful to say -- the commit is even marked specially as a merge commit. Other than bringing in one branch (which has hopefully been correctly commented) no changes were made.
So really, what do you want them to say?
Re:Linus: please write good git commit messages
by arkitaip on Sunday November 27, 2011 @12:58PM
(#3282892)
Ah, but what if we encouraged programmers to write better commit messages? What if we splashed on a bit of gamification to raise everyone's level of awareness? Maybe a badge on your profile page...?
Re:Linus: please write good git commit messages
by drivingmenuts on Sunday November 27, 2011 @01:05PM
(#3282913)
How would you objectively determine the usefulness of a commit message, though? While it might contain all the necessary parts, there is no way to determine if the sum of the parts adds up to a useful whole.
Also, badges are done to death. Everyone's got badges these days - so much so they're like ads. Personally, I've developed a blind spot to most of them.
Re:Linus: please write good git commit messages
by arkitaip on Sunday November 27, 2011 @01:49PM
(#3283052)
Objectivity is irrelevant and impossible in this context of raising awareness and fun. If the mechanism was something as simple as an upvote next to the commit message, you would let the community define usefulness of the commit message.
Re:Linus: please write good git commit messages
by andrewflnr on Sunday November 27, 2011 @04:55PM
(#3283530)
Upvoting itself might be all you need.
GitHub's online editor has a default commit message along the lines of "Edited path/to/file", and I see a lot of pull requests with that message, and nothing else. That's about the most useless message possible, since it adds no information that isn't already implicit in the commit. It would be better to leave it blank and force users to at least write _something_.