News for hackers. Stuff that matters.
Re:Leaving Facebook/Meta was the best thing we could do for ... by avalys on Wednesday August 03, 2022 @12:23AM (#32327646)
For a long time, it was worse than that - once a change was "accepted", you could amend the commit with changes to literally any other file in the entire monorepo, and land it without any further review.

They finally added a "final review" step to ensure that someone eventually takes a look at these changes after the initial accept, but that still occurs several days after the commit.

Re:Leaving Facebook/Meta was the best thing we could do for ... by toast0 on Wednesday August 03, 2022 @12:34AM (#32327688)
Can you still add

Reviewed-by: yourself

in the commit message to skip review? That was my favorite one.