News for hackers. Stuff that matters.

A comment on Making a PR to Nixpkgs. Parent comment

Re:Making a PR to Nixpkgs by saagarjha on Tuesday August 02, 2022 @02:58AM (#32315885)
Pull requests are great, you just need to be mindful of what commits you're sending people. Every commit I put in a PR is a commit I made with intent. Just squashing them all does them a disservice.
[ Parent | on HN ]
Re:Making a PR to Nixpkgs by alexchamberlain on Tuesday August 02, 2022 @04:07AM (#32316219)
I don't know how many times I've said that reviewing the structure of the commits is part of a PR, just like reviewing the code. It seems to be a revelation.
[ Parent | on HN ]