Making a PR to Nixpkgs

Re:Making a PR to Nixpkgs by e3bc54b2 on Tuesday August 02, 2022 @01:49AM (#32315533)

That is what I dislike about the Pull Request workflow. It encourages piling on commits, polluting commit log (not to mention useless merge commits). To this day I haven't found anything better than Gerrit for reviewing changes across iterations. I wish it makes a comeback on broader scale.

[ Parent | on HN ]

Re:Making a PR to Nixpkgs by saagarjha on Tuesday August 02, 2022 @02:58AM (#32315885)

Pull requests are great, you just need to be mindful of what commits you're sending people. Every commit I put in a PR is a commit I made with intent. Just squashing them all does them a disservice.

[ Parent | on HN ]

Re:Making a PR to Nixpkgs by alexchamberlain on Tuesday August 02, 2022 @04:07AM (#32316219)

I don't know how many times I've said that reviewing the structure of the commits is part of a PR, just like reviewing the code. It seems to be a revelation.

[ Parent | on HN ]

Re:Making a PR to Nixpkgs by johnny22 on Tuesday August 02, 2022 @06:54AM (#32317132)

luckily github can just squash it for you if you choose. You don't have to have a useless merge commit. The option is right there in the dropdown. I assume gitlab as well.

[ Parent | on HN ]