News for hackers. Stuff that matters.
Re:Ask HN: What tone to use in code review suggestions? by Thorrez on Tuesday June 28, 2022 @01:43AM (#31904502)
Where I work there is a readability review like mason55's (probably the same company). Most of the comments I see are not about formatting. They're more like "Take parameters by std::string_view instead of const std::string&" or "Use a reference member instead of a pointer member if it'll never be null."

Applying a linter to a giant company-wide monorepo can be difficult because of decades-old code that predates certain style rules, or some teams that might have created their own rules. Even if the linter only applies to diffs, a small change to a line can trigger a lint warning on that line, and having a ton of those can be annoying.

There are no comments on this comment yet.