News for hackers. Stuff that matters.
Re:Ask HN: What tone to use in code review suggestions? by darekkay on Monday June 27, 2022 @04:40PM (#31900486)
We do something very similar:

* NICE: Optional change. PR is approved.

* SHOULD: Highly suggested change. PR is neither approved nor rejected.

* MUST: Must be fixed. PR is rejected.

This also helps the PR author to know which of my comments have to be addressed to resolve my rejection.

There are no comments on this comment yet.