News for hackers. Stuff that matters.
Re:Ask HN: What tone to use in code review suggestions? by jszymborski on Monday June 27, 2022 @12:59PM (#31897374)
Just wanted to chime in and say that I still remember the first code reviews I received and while I didn't take any of the comments personally, they certainly didn't feel great to receive. (I should add that I don't begrudge the reviewers, they were nice people).

These example notes are wonderful. They feel like an editor's notes, not a graded exam. Something you'd get from a colleague who is collaborating with you and not some infallible black-box oracle.

Re:Ask HN: What tone to use in code review suggestions? by IncRnd on Monday June 27, 2022 @01:24PM (#31897744)
Thanks!
Re:Ask HN: What tone to use in code review suggestions? by glouwbug on Monday June 27, 2022 @08:00PM (#31902490)
It's your standard Socratic Method[1] that's devised to help you (the learner) arrive at solutions on your own terms. Just don't push it too deep - others may become a little too annoyed, and, well, read up on Socrates to learn what happens next

[1] https://en.wikipedia.org/wiki/Socratic_method