Ghost 5.0 - Hackdot

Re:Ghost 5.0 by fbn79 on Monday May 23, 2022 @09:33AM (#31478816)

Any good reason for the project to still need "bluebird" as deps?

[ Parent | on HN ]

Re:Ghost 5.0 by erisds on Monday May 23, 2022 @09:55AM (#31479087)

Good question, the short answer is no :)

The long answer is it's absolutely everywhere in our codebases, with some code relying on catch-predicates, meaning we have to pull it out in exactly the right order else things will break in weird ways... and we haven't gotten around to tackling that yet.

Would love to get some help to get it out though - I raised an issue here: https://github.com/TryGhost/Ghost/issues/14882

[ Parent | on HN ]

Re:Ghost 5.0 by Dave3of5 on Monday May 23, 2022 @03:39PM (#31483945)

> Would love to get some help to get it out though

Is this genuine ? So If I created a small PR refactoring out a bluebird style promise to native node it would be merged ?

[ Parent | on HN ]

Re:Ghost 5.0 by ushakov on Monday May 23, 2022 @09:58AM (#31479125)

i have the same question about jQuery and lodash (underscore) use in Ghost

do you have a plan to modernise these parts?

[ Parent | on HN ]

Re:Ghost 5.0 by jtwebman on Monday May 23, 2022 @10:59AM (#31479857)

I still use Bluebird library for things like property based promises resolutions and the map is a quick way to run only so many promises at a time instead of all of them or in series.

[ Parent | on HN ]