News for hackers. Stuff that matters.
Re:Flags Are a Code Smell (2014) by jef_leppard on Saturday May 21, 2022 @07:58PM (#31463443)
If you find yourself passing in flags to change behavior, it sounds like you should just have two functions. For other cases, an enum might serve your needs better as it gives you more options as your codebase grows. That said, I wouldn't call boolean flags a _smell_. Seems like throwing out the baby with the bath water if you ask me.
Re:Flags Are a Code Smell (2014) by amelius on Saturday May 21, 2022 @08:15PM (#31463566)
Yeah, it's either flags or duplicating code. Both are smelly, so pick your poison.
Re:Flags Are a Code Smell (2014) by jackblemming on Sunday May 22, 2022 @01:26AM (#31465117)
No? Both separate functions can call a 3rd shared function if they want.

You can also restructure the code with dependency injection. There's plenty of options that don't require duplication

Re:Flags Are a Code Smell (2014) by amelius on Sunday May 22, 2022 @05:39AM (#31466415)
Alas, in reality the code controlled by the flag is often mixed with other code and separating the two is often difficult to do right, e.g. requiring to pass a lot of data hence and forth.
Re:Flags Are a Code Smell (2014) by gentleman11 on Sunday May 22, 2022 @12:57PM (#31470270)
That indirection can end up a bit fractal. Sometimes the duplication is less bad than the readability reduction. You have to trust your intuition at those times
Re:Flags Are a Code Smell (2014) by jef_leppard on Sunday May 22, 2022 @01:32AM (#31465149)
Yep. You said it better than I could. There are a lot better ways to do control flow than passing in a flag. Inversion of control being another great example.
Re:Flags Are a Code Smell (2014) by tbrownaw on Sunday May 22, 2022 @01:14AM (#31465065)
Duplication is for when future changes are independent. "This client wants their reports customized" maybe.

Flags are for when future changes affect both options. "On top of the usual functionality, we can also optionally handle this other related thing" or so. Or --dry-run handling.

Re:Flags Are a Code Smell (2014) by jef_leppard on Sunday May 22, 2022 @01:29AM (#31465136)
Eh maybe. Theres no hard and fast rules in this business for sure but when I'm dealing with pure business logic, if I am passing flags in that make the function behave in more than one way, I'll try my damndest to refactor until there is one and only one thing that that function does. If I _had_ to pass in a flag, then I'd make a top level function that mostly did flow control and called into functions that had straight line logic paths. Something like this (using enums instead of booleans):

    function doTheThing({typeOfThing, ...rest}) {
        if (typeOfThing === Thing.FOO) {
           doThingWithFoo(rest)
        }
    
        if (typeOfThing === Thing.BAR) {
           doThingWithBar(rest)
        }
    }