News for hackers. Stuff that matters.
Re:NPM Vulnerability Discussion on Twitter by leodriesch on Tuesday May 10, 2022 @09:35AM (#31326947)
I don’t get why anyone would introduce a dependency this small to their codebase.

It’s a much better choice to just copy the source code and possibly license into your own code to just eliminate the overhead.

It’s not like any of these packages depend on being updated for security reasons or anything.

Re:NPM Vulnerability Discussion on Twitter by chrisfosterelli on Tuesday May 10, 2022 @12:17PM (#31328884)
At risk of criticism, I'll bite. I used to think this way and include a lot of small dependencies in most projects I worked on.

The thinking was as follows: Of course you could just copy the code, but then that increases LOC in my codebase that I'm responsible for. More code is more work. Lines in a dependency are the responsibility of someone else. If there's a bug, even in a small function, the community can identify it and fix it. I can get new features I might not have known I needed. I can benefit from all of these fixes indefinitely into the future without ever having to have any mental overhead about that code. So can everyone else; it's good to maximize code reuse.

I don't think I've ever used something that could be an obvious one-liner like `isOdd` but for lots of only slightly more complex stuff like left-pad, email format validation, GPS coordinate math functions -- all stuff that's really less than 30 lines -- it was really nice to just not have to think about the implementation details of that and get back to solving your problem. I could have reviewed the code or written it myself but it's just more work when remaining at a high level `leftPad()` call let's me stay focused on my original task.

That said, I've since realized I was wrong of course. Trying to maintain projects that haven't been touched in more than a year led to hours of fixing dependency issues. We switched to using dependabot, which is better, but just makes it obvious how much work it actually is to keep dependencies up to date week-to-week. Then there's all of the security issues. These days, for small packages, I advocate for reviewing the code from these packages, ensuring we understand it, and then copying it in directly with a comment for attribution. We generally try to keep dependencies low; still more than in other languages but at least some thoughtfulness about whether it's "worth it". I think a lot of the community has shifted similarly, but there's still a lot of older projects with older dependencies.

Re:NPM Vulnerability Discussion on Twitter by pilif on Tuesday May 10, 2022 @12:45PM (#31329257)
> Of course you could just copy the code, but then that increases LOC in my codebase that I'm responsible for.

Once your company is owned by a supply chain attack or by an RCE in one of your dependencies, you will learn that you are in-fact very much responsible for the code in your external dependencies.

Re:NPM Vulnerability Discussion on Twitter by tylersmith on Tuesday May 10, 2022 @03:30PM (#31331522)
This drives me crazy. If your software is using a library that library is part of your software whether you originated its code or not. If you are responsible for the software then you're responsible for the LOC in every library your software depends on.
Re:NPM Vulnerability Discussion on Twitter by bin_bash on Tuesday May 10, 2022 @09:54AM (#31327128)
I think a lot of it is from a single engineer: sindresorhus

He’s a prolific open source author that traditionally had a lot of modularization in his packages—though I think he has started to move away from it recently. He talks about it here: https://blog.sindresorhus.com/small-focused-modules-9238d977...

Most projects will include at least one package by him in the dependency tree.

Re:NPM Vulnerability Discussion on Twitter by sanitycheck on Tuesday May 10, 2022 @11:06AM (#31327999)
Funnily enough, I was just digging through my current project's dependencies and he's slipped in via a Rollup plugin which uses his "globby" package, which in turn uses his "slash" package.. Slash is about 5 lines of code, which is roughly 4 more than most people need for what it does.

I vastly prefer to use libraries with 0 dependencies but I never quite manage it, so I end up with the same problems as everyone else.

Re:NPM Vulnerability Discussion on Twitter by nobleach on Tuesday May 10, 2022 @12:15PM (#31328863)
For years, the bane of my existence was always lodash. Import one tiny utility and it brings along 15 of its closest friends. You can't get away from it. It was built so incredibly modularly, that it has to import a bunch of other things. Now most folks will quickly rush to its defense and tell you that Webpack should be able to tree-shake it well enough. My actual experience is that it was a tremendous waste of my customers' bandwidth. Seeing LoDash as a dependency of anything I use is an immediate NOPE for me. I've yet to see anything it provides that I couldn't just do myself.

It's an unpopular opinion for some silly reason. It's like when Guava or Apache Commons was included on every single Java project in the 2010s. "It's just so much easier to use a well-tested library". That line of thinking is what got us here.

Re:NPM Vulnerability Discussion on Twitter by sanitycheck on Tuesday May 10, 2022 @01:01PM (#31329457)
I'm the opposite, I tend to be relieved when I see lodash as a dependency. In any normal sized project I'm probably already using it, or it's already a dependency of a dependency. I trust it a lot more than a hundred tiny libs by random authors, both in terms of sketchy behaviour and reliability/performance. If I need to target platforms which don't support modern JS I vastly prefer to stick to lodash than use a bunch of polyfills of unknown quality.

The individual functions are installable separately from NPM, and lodash-es should tree-shake quite well, but I do know what you mean about it dragging in its internal dependencies so you end up with a 15kb of lodash code for a single thing. I probably wouldn't love to use it client-side on an ordinary website, were I to make one.

Re:NPM Vulnerability Discussion on Twitter by thatwasunusual on Tuesday May 10, 2022 @09:58AM (#31327176)
> I don’t get why anyone would introduce a dependency this small to their codebase.

This might be controversial, but I think it has to do with less experienced developers, beginners, who doesn't know how to find out via "pure code" if a number is even or not, or even if something is a number (IIRC, there is an isNumber package out there as well).

I see this in other languages as well, but not in a "JavaScript scale", but that could probably just mean that the language's availability and popularity decides the number of "stupid packages."

Re:NPM Vulnerability Discussion on Twitter by BigJono on Tuesday May 10, 2022 @10:15AM (#31327395)
Let's call a spade a spade. It's a bunch of noobs that have become the majority and created a culture of dependency-first development.

I haven't worked with anyone for years that doesn't start troubleshooting an issue by reaching for a random dependency. They just don't even bother learning Javascript or the Web APIs or CSS anymore. Without a solid base of fundamentals every trivial problem seems insurmountable so they just don't even try.

Re:NPM Vulnerability Discussion on Twitter by ratww on Tuesday May 10, 2022 @10:39AM (#31327673)
If we're going to call a spade a spade, then let's go ahead and say that the majority of the packages that are always referenced in those discussions (is-even, is-odd, etc) is maintained and primarily used by a minority of developers that are very well known in the ecosystem.

This minority makes money out of their popularity in the NPM ecosystem. Having 1000 NPM packages is better for your reputation than having 100. And having all 1000 packages with lots of weekly downloads is better than having just a portion of that.

But how do they achieve that? Well, they have 1000 NPM packages, so each one depends on 5 to 10, that then depends on a few handful more. You have packages for checking if an HTTP status is a certain number, you have packages that have colors as constants, you have is-even, is-odd and so on. All that exists to maintain that closed ecosystem.

So out of the 1000 they basically have 20 useful tools and 980 garbage packages that exist only to maintain their own ecosystem.

Most people isn't using is-even or is-odd directly. They imported some other packages that are quite useful, but often need 10-20 sub-dependencies. Another interesting thing is that those shitty packages aren't really that important in applications. They're often used in build tools, CI and testing, tools for making CLI tools, and the sort.

The crazy thing is that a lot of people using is-even/is-odd aren't really "noobs": they're probably experienced developers that said "fuck it, I'll use some random tool from the web" when facing some random a problem.

Re:NPM Vulnerability Discussion on Twitter by Tainnor on Tuesday May 10, 2022 @11:02AM (#31327944)
That's a more charitable (and more reassuring) interpretation than "developers don't know the modulo operator".

That said, it still leaves a sour taste as this effectively implies that a certain set of JS developers is very happy to abuse their (maybe initially rightfully earned) prestige to gain even more prestige while leaving behind a mess for the whole ecosystem. I don't understand why this is tolerated. The Node community needs to have a serious discussion about why certain packages are allowed to spread garbage, create forks of the relevant packages that rip out "is-even" etc. and then eventually converge to these forks. But to this day, I don't see the community taking this problem seriously enough.

Now, supply chain attacks and "too many dependencies" are a potential issue for every language with dependency management (see also log4j, etc.), but no other ecosystem seems to be have such a high frequency of issues and (widely used) "is-even" packages are simply not a thing in any other mainstream language (some languages, like Swift, include similar functionality in the standard library, which is totally fair).

Re:NPM Vulnerability Discussion on Twitter by ratww on Tuesday May 10, 2022 @02:28PM (#31330657)
The reason it is tolerated is because the philosophy of "thousands of small packages" has spread far and wide.

For every person calling it out like we're doing here, there are ten others praising maintainers able to whip ten semi-useless packages per week.

It's not just random maintainers making small packages. The core infrastructure of Javascript is in it. Babel is made of hundreds of packages, which all live on the same repository (because of course the maintainers don't want the hassle of maintaining multiple things). Some of those packages don't even have anything of importance in it, just metadata, a couple flags and some boilerplate [1]. The package is just a way of organizing code. Webpack, ESLint and others aren't exactly better.

EDIT: And of course I got downvoted :)

[1] https://github.com/babel/babel/blob/main/packages/babel-plug...

Re:NPM Vulnerability Discussion on Twitter by cxr on Tuesday May 10, 2022 @03:17PM (#31331358)
You're tacitly giving the people you despise leverage when you say things like:

> The core infrastructure of Javascript is in it. Babel[...]

Babel is not core JS infrastructure. It may be close to fundamental to the modern NodeJS development experience, but JS exists happily (and capably) without any of that stuff (including package.json, for that matter).

Re:NPM Vulnerability Discussion on Twitter by ratww on Tuesday May 10, 2022 @04:40PM (#31332394)
Fair enough! True, Babel is only "core" for a subset of JS developers, not for the language.

I don't really despise anyone in Babel, though, I'm only criticising their packaging method. Babel isn't doing the million-packages thing to gain popularity.

Re:NPM Vulnerability Discussion on Twitter by bostik on Tuesday May 10, 2022 @12:41PM (#31329194)
> Having 1000 NPM packages is better for your reputation than having 100. And having all 1000 packages with lots of weekly downloads is better than having just a portion of that.

Should we treat them as spammers and polluters, then? Because if what you describe is true, that deserves to be called out and mowed to the ground.

Re:NPM Vulnerability Discussion on Twitter by ratww on Tuesday May 10, 2022 @02:10PM (#31330391)
Definitely.

It is more akin to SEO spamming than black market spamming, though. They're polluting NPM in the same way SEO farms spam Google. It makes life difficult for everyone, but it's still a gray area in terms of legitimacy. Which is why nobody really talks about it.

Re:NPM Vulnerability Discussion on Twitter by sdoering on Tuesday May 10, 2022 @01:22PM (#31329711)
I don't know if this is true, but if it were true you'd have a veritable "tragedy of the commons" [0] situation were privatization of (some) gains leads to the creation of negative externalities for the rest.

If incentives were aligned differently, different results might have resulted. Probably with different externalities (or unintended consequences).

[0]: https://en.wikipedia.org/wiki/Tragedy_of_the_commons?wprov=s...

Re:NPM Vulnerability Discussion on Twitter by thatwasunusual on Tuesday May 10, 2022 @12:02PM (#31328704)
> Most people isn't using is-even or is-odd directly. They imported some other packages that are quite useful, but often need 10-20 sub-dependencies.

IMO, that's even worse, because that means that a lot of people are using stupid and vulnerable packages without knowing it.

I wish there was some sort of better control over the NPM directory, where someone could block/downvote (or whatever) packages that doesn't deserve to live. How this would - or should - work in practice, I have no idea, but it's just getting scarier by the day to import a package in your application.

Re:NPM Vulnerability Discussion on Twitter by ratww on Tuesday May 10, 2022 @02:33PM (#31330728)
The problem is that those fame-chaser maintainers aren't the only ones doing it. Babel does it. Webpack does. ESLint does it. Before them others did.

If we ban those, we'd have to ban Babel and Webpack too... Oh now, wait a minute, now that actually sounds interesting...

Re:NPM Vulnerability Discussion on Twitter by thatwasunusual on Wednesday May 11, 2022 @10:00AM (#31340047)
Wow. You must be a special kind of stupid?

What if we focused on fixing all the problems, and not just retreating thinking that "we can't solve this problem, because there are so many other problems related to it"?

Your thinking is literally the definition of the problem.

Re:NPM Vulnerability Discussion on Twitter by cobertos on Tuesday May 10, 2022 @12:33PM (#31329087)
A few developers will register multiple packages that are essentially the same package with small tweaks. They choose the names in a way to get the right keywords to hit from npmjs's search
Re:NPM Vulnerability Discussion on Twitter by ZetaZero on Tuesday May 10, 2022 @10:23AM (#31327489)
If a developer doesn't know how to write their own "iseven", I don't want their product.

Maybe you could argue other for other reasons to use these packages.

Re:NPM Vulnerability Discussion on Twitter by haswell on Tuesday May 10, 2022 @11:58AM (#31328647)
I suspect a lot of this use doesn’t go into products, it goes into projects.
Re:NPM Vulnerability Discussion on Twitter by zzyzxd on Tuesday May 10, 2022 @01:00PM (#31329450)
Comparing to:

1. search for a package that does X

2. scan the search result and find the package that really does X

3. learn to use the package's API

4. import the package in the code

5. use it

Isn't it much easier to just copy-paste code from stackoverflow? There's also a good chance that the you can get some very good explanation and interesting discussion around the implementation there.

Re:NPM Vulnerability Discussion on Twitter by ratww on Tuesday May 10, 2022 @04:55PM (#31332593)
Well, yes.

There's also Github Copilot, which pretty much replaced almost my entire usage of Stack Overflow.

But the thing is that with a rando package is that one doesn't have to review the code. Sure, the code is also coming from somewhere else. Sure, it might never get updated. Sure it might be full of bugs. Sure, it might be more dangerous than copying from StackOverflow. But out of sight, out of mind.

In the end the overuse of packages isn't about saving time or "doing the best for business" or "ensuring that the code is maintained by someone else". It's purely about covering our asses.

Re:NPM Vulnerability Discussion on Twitter by xboxnolifes on Wednesday May 11, 2022 @12:04PM (#31341892)
I feel it's more likely related to how often "don't reinvent the wheel" and "NIH syndrome" is thrown around. It's no surprise to me that people will first check to see if a library already exists before going to write their own, probably lacking function.
Re:NPM Vulnerability Discussion on Twitter by duxup on Tuesday May 10, 2022 @10:09AM (#31327314)
I find that I do that more often now than ever.

Most times I get the urge to pull in a rando package I find I really only need a few things it does. I check it out. Read it. Write my own.

I almost never need "all the things" outside the situations where I am using a big framework. So reading it, getting inspired / ideas from someone who did the thing and then I write a much more narrow focused version for myself.

Re:NPM Vulnerability Discussion on Twitter by megous on Tuesday May 10, 2022 @04:45PM (#31332468)
And you can easilly add the features you actually need. :)
Re:NPM Vulnerability Discussion on Twitter by Merad on Tuesday May 10, 2022 @12:16PM (#31328876)
4-5 years ago (when the popularity of node was skyrocketing but es6 was still relatively new) I remember some people arguing passionately that it was good to maximize code reuse, i.e. better to pull in a package with one utility than to write 5 lines of code in your own application. I think it was mainly a symptom of the gaping holes in javascript's standard library... thankfully that attitude seems to have mostly died off.
Re:NPM Vulnerability Discussion on Twitter by remram on Tuesday May 10, 2022 @02:49PM (#31330967)
> possibly license into your own code

This can be complicated. Depending on another package is usually very safe, at least as safe as "dynamic linking", but including code in your own source tree needs licenses to be compatible. Even then, you might have to change your license to "BSD-3-Clause + ISC" or similar composite and you will get complaints from users.