News for hackers. Stuff that matters.
Re:Achievement unlocked: rustc segfault by EE84M3i on Sunday April 10, 2022 @08:13PM (#30983120)
In either case dereferencing a null pointer would still be a bug, right? Or is it kind of "all bets are off" if you feed LLVM bad IR and don't enable verification?
Re:Achievement unlocked: rustc segfault by tedunangst on Sunday April 10, 2022 @09:50PM (#30983669)
If you call free((void *)-1) in C code, it will very likely crash, but it will crash in libc, not your program. Is that a bug in libc?
Re:Achievement unlocked: rustc segfault by MaxBarraclough on Monday April 11, 2022 @03:47PM (#30993835)
I think even deriving the argument might invoke undefined behaviour here, but I'm not certain.

If I understand correctly, it's undefined behaviour to do this:

    int *ptr = (int*)42;
As, in order to avoid undefined behaviour, ptr should only be assigned a valid address of an int, or the 'address' one past the end of an array of int, or NULL (logical zero).

It's possible things are different when the type is void*, I'm not certain.

Re:Achievement unlocked: rustc segfault by tedunangst on Monday April 11, 2022 @04:19PM (#30994317)
Make it free(free) if you want it to be a valid pointer.
Re:Achievement unlocked: rustc segfault by kelnos on Friday April 15, 2022 @12:51AM (#31036691)
No, because the defined contract for free() is that you pass it a pointer that was previously returned from malloc(), that you don't try to free() it twice, etc.
Re:Achievement unlocked: rustc segfault by Thorrez on Monday April 11, 2022 @12:15AM (#30984598)
That's documented undefined behavior.

Is it documented undefined behavior to feed bad IR into LLVM?

Re:Achievement unlocked: rustc segfault by scatters on Monday April 11, 2022 @02:51AM (#30985487)
Of course. If there's an input checking mode, and you disable the checks, then you're guaranteeing that you won't supply invalid input.
Re:Achievement unlocked: rustc segfault by mshockwave on Sunday April 10, 2022 @09:39PM (#30983605)
LLVM makes trade off on enabling/disabling certain checks, including assertions and IR verification, primarily to keep compilation time acceptable in release build. The idea is that we catch as many bugs as possible in debug version of LLVM such that release version can run fast.
Re:Achievement unlocked: rustc segfault by theresistor on Sunday April 10, 2022 @08:53PM (#30983351)
LLVM makes use of assertions to validate things like this, but many users of LLVM, including rustc, turn them off for performance reasons.
Re:Achievement unlocked: rustc segfault by comex on Sunday April 10, 2022 @08:23PM (#30983180)
It is.
Re:Achievement unlocked: rustc segfault by eyelidlessness on Sunday April 10, 2022 @08:48PM (#30983328)
Terse affirmative is ambiguous.
Re:Achievement unlocked: rustc segfault by nlewycky on Sunday April 10, 2022 @09:44PM (#30983634)
If you feed LLVM bad IR, all bets are off. LLVM's assertions and IR verifier are impressively comprehensive, but not a guarantee.

For example, LLVM has a pointer type and a void type, but you may not make a pointer-to-void type, see https://llvm.org/docs/LangRef.html#pointer-type . If you do call `Type::getVoidTy(C)->getPointerTo()` then LLVM will hit an assertion only in a build with assertions enabled. Without assertions LLVM may silently execute UB.

Re:Achievement unlocked: rustc segfault by akimball on Monday April 11, 2022 @08:15AM (#30987637)
As are all tautologies;)