Re:Gitlab – Static passwords set during OmniAuth-based regis...
by mdaniel on Friday April 01, 2022 @02:15PM
(#30881486)
> I could easily imagine myself missing this when reviewing the PR "oh it's just changing a whole bunch of specs, go ahead".
That's one of the major benefits of the "tree view" in MRs, because one can collapse the "spec" folder, collapse the "ee/spec" folder, and it leaves "db" and "lib/gitlab/auth" visible which should for sure set off mental alarm bells: https://docs.gitlab.com/ee/user/project/merge_requests/chang...
That's one of the major benefits of the "tree view" in MRs, because one can collapse the "spec" folder, collapse the "ee/spec" folder, and it leaves "db" and "lib/gitlab/auth" visible which should for sure set off mental alarm bells: https://docs.gitlab.com/ee/user/project/merge_requests/chang...