News for hackers. Stuff that matters.
Re:The Code Review Pyramid by jamesfinlayson on Tuesday March 22, 2022 @09:23PM (#30773775)
This - last year I broke something because I'd changed a query in a file completely unrelated to the ticket I was working on, and the guy who did the review treated code review as a rubber-stamp - he completely ignored the fact I'd accidentally committed a change to payment processing code in a patch to tighten up company number validation.
Re:The Code Review Pyramid by patrickwalton on Tuesday March 22, 2022 @11:12PM (#30774451)
Even if code reviewers only made sure the files changed made sense, the reviews would be worth it.