Re:The Code Review Pyramid
by jamesfinlayson on Tuesday March 22, 2022 @09:23PM
(#30773775)
This - last year I broke something because I'd changed a query in a file completely unrelated to the ticket I was working on, and the guy who did the review treated code review as a rubber-stamp - he completely ignored the fact I'd accidentally committed a change to payment processing code in a patch to tighten up company number validation.
Re:The Code Review Pyramid
by patrickwalton on Tuesday March 22, 2022 @11:12PM
(#30774451)
Even if code reviewers only made sure the files changed made sense, the reviews would be worth it.
The other thing I think is easy to do is simply see if you understand the code. If the reviewer struggle to do understand what's going on, chances are that other people will struggle as well. In this case, your lack of knowledge is an asset, the original author is likely to not see how it looks for someone not as well versed with the problem.