News for hackers. Stuff that matters.
Re:Why is the Zoom app listening on my microphone when not i... by adam_ellsworth on Tuesday February 08, 2022 @09:21PM (#30267879)
Thank you. And thank you for making it open source.

Concerning this line: https://github.com/arkadiyt/zoom-redirector/blob/master/back... Why is it sometimes returning undefined? (or is that known)?

Cheers!

Re:Why is the Zoom app listening on my microphone when not i... by arkadiyt on Tuesday February 08, 2022 @10:41PM (#30268497)
> Thank you. And thank you for making it open source.

Sure thing. All browser extension source code is available to you anyhow, even if the author doesn't publish it.

> Why is it sometimes returning undefined?

Looks like a simple bug as some folks below have pointed out. It doesn't impact the functionality of the extension in any way here.

Re:Why is the Zoom app listening on my microphone when not i... by squeaky-clean on Tuesday February 08, 2022 @09:36PM (#30267992)
Not the developer but nice catch. const match would be null, not undefined, if the regex search does not match, right?
Re:Why is the Zoom app listening on my microphone when not i... by cipherboy on Tuesday February 08, 2022 @09:53PM (#30268127)
In a browser console:

> const match = /^\/[js]\/(\d+)\/?$/.exec("something")

> undefined

Re:Why is the Zoom app listening on my microphone when not i... by eatingCake on Tuesday February 08, 2022 @10:27PM (#30268396)
The assignment to match returns undefined. The value of match is null.
Re:Why is the Zoom app listening on my microphone when not i... by femto113 on Tuesday February 08, 2022 @10:46PM (#30268527)
To be pedantic the assignment returns null (always returns the rvalue[1]), it's the const statement that produces undefined[2]

[1] https://tc39.es/ecma262/multipage/ecmascript-language-statem... [2] https://tc39.es/ecma262/multipage/ecmascript-language-statem...

Re:Why is the Zoom app listening on my microphone when not i... by cipherboy on Tuesday February 08, 2022 @10:47PM (#30268548)
And to be even more pedantic, the function works because it is applied on an event listener... When null[1] is evaluated (in the right side of the || of the conditional), it produces a TypeError... which in effect (due to no catch and evaluation continuing in a parent/event-driven scope) is essentially equivalent to an empty return in this specific context.

What fun! :-)

Edit: apparently as also mentioned https://news.ycombinator.com/item?id=30268412

Re:Why is the Zoom app listening on my microphone when not i... by zeven7 on Tuesday February 08, 2022 @10:38PM (#30268475)
Run just /^\/[js]\/(\d+)\/?$/.exec("something") in the console
Re:Why is the Zoom app listening on my microphone when not i... by vinayakpandey on Tuesday February 08, 2022 @10:18PM (#30268335)
A function returns undefined if any value was not returned.
Re:Why is the Zoom app listening on my microphone when not i... by chrismorgan on Tuesday February 08, 2022 @10:30PM (#30268412)
True generally, but irrelevant here: the function in question is RegExp.prototype.match. By definition, it never returns undefined, but only an array or null. The only way `match == undefined` could be true would be if smething had overridden RegExp.prototype.match, which would be… surprising and worthy of explicit note.

Also match[1] will never be undefined: it’ll either throw an exception, or be a string. No, this is just a bug, a poorly written guard that fails to guard what it was supposed to, and I suppose an exception is just silently swallowed and treated equivalently to the intended early return. But the clause should be changed to just `if (!match) return;` or similar.

Re:Why is the Zoom app listening on my microphone when not i... by olliej on Wednesday February 09, 2022 @01:12AM (#30269515)
Quick heads up you may want to update that to be === rather than ==, because of course JS is wonderful and null does == undefined (not a nerd snipe, I was just confused by your comment and went and looked at the code, and realized it was likely a typo :) )
Re:Why is the Zoom app listening on my microphone when not i... by chrismorgan on Wednesday February 09, 2022 @07:31AM (#30271869)
Yeah, unfortunate typo, thanks for the correction. I spend most of my time writing Rust, and when I’m writing JavaScript I type !== and === naturally, but I think writing this comment I just didn’t quite switch into JavaScript mode.