The commit message is lazy, but breaking these into separate commits because of some "also" rule of thumb is just blindly following a rule for the sake of it.
Agreed, cargo-culting is always bad!
But, without knowing how OBS development team works, sometimes it does make sense to split commits like this, mainly if you have a larger repository where different people are responsible for different areas in the codebase.
For example, build-scripts sometimes gets managed by other people than the ones writing some core algorithms, who are also different from the people writing public APIs to be consumed by users. In those cases, it makes reviews a lot easier when you can split out to review different commits to different people, instead of having everyone navigate the same commit.
But again, not familiar with the internals nor the development cycle that OBS keeps, so maybe this doesn't make sense in this case.
This commit is based off a branch that was adding support for Apple Silicon.
So the entire PR is not going to look clean until that branch is merged first.
> ...you can't revert just one without reverting the others
That's often true in a split out patchset anyway, so I don't think that on its own it stands as a justification for doing things one way or the other.
Ruthless interactive rebase is one way to fix that last point, but if you take the final result and squash that into a single changeset, there's a point to be made about that as well.
Of course, when merged, it often makes sense to squash some commits together, just like you say - long-term, many of the feature development details are not important.
It's not an either-or proposition.