I'm not a big fan of that, but I would prefer that it reflect the harm done from the crime and the statistics surrounding recidivism.

A simple drug possession offense should not warrant banning you from voting or guns when you are done. If you were convicted of an armed robbery, maybe the guns should be banned.

I really don't like the idea that once you're done with the justice system it continues to punish you. Once you are done with it, you should be done--especially if the crime was "victimless" (ie. something like drug possession where the only harm would be to yourself).

This becomes a significant issue in, for example, sex offenders. Some places have so many restrictions on sex offenders that, for all intents and purposes, they cannot comply with probation and cannot function in society. Well, if you're going to do that, at least be honest that you are simply "executing them on the cheap and out of sight" and either keep them in prison or execute them explicitly.

This is one of the problems with low-level drug convictions--the "felony" conviction becomes a poor man's "social discredit" system. And most of us from Western democracies understand pretty solidly why "social credit" systems are pernicious.