News for hackers. Stuff that matters.
Re:ImageGlass added malware with this commit by geewee on Saturday January 22, 2022 @10:52AM (#30037680)
Reading the issue it seems to have been removed in the latest version.

On a semi-related note: Woof, issues like that make me want to never do open source again. Did that guy make a mistake? Obviously. Was it in good faith? It seemed so. Were people jerks even after he fixed it. Absolutely.

Re:ImageGlass added malware with this commit by BugsJustFindMe on Saturday January 22, 2022 @11:04AM (#30037811)
> Did that guy make a mistake? Obviously. Was it in good faith? It seemed so.

Adding unwitting users' computers to a proxy network by default is so obviously and blatantly unethical, it beggars belief. I'm not angry at the creator, because they seem oblivious. I am, however, extremely saddened and frustrated by their obliviousness. Like in no universe is it ever OK to do this even if nobody responds to your discord poll. It takes a real failure in responsible, ethical upbringing to get here. It takes a lack of consideration and empathy for other people to believe that including this isn't an act of aggression towards everyone who encounters the software.

Re:ImageGlass added malware with this commit by omginternets on Saturday January 22, 2022 @11:15AM (#30037916)
I personally have a very hard time believing they are oblivious. It’s a literal caricature of malware. There is no way one could think it wouldn’t cause this kind of reaction. The best one could hope for is that people don’t notice.
Re:ImageGlass added malware with this commit by BugsJustFindMe on Saturday January 22, 2022 @11:24AM (#30038007)
I want to be able to agree with you, but too much of the world is poisoned by toxic "me before you" society. There's a high probability that this person just never learned to recognize and challenge behaviors like this. So, maybe, but also maybe not. Either way it's sad.
Re:ImageGlass added malware with this commit by treesprite82 on Saturday January 22, 2022 @11:53AM (#30038314)
> Like in no universe is it ever OK to do this even if nobody responds to your discord poll

As far as I can tell, they didn't even really make a Discord poll.

The first mention of "spider" (or "IP" or "proxy" or any related words) is from the release announcement of a version which already contains Spider, which got negative reactions: https://i.imgur.com/gLKce8W.png

It's very deceptive wording since "I made an announcement to poll people's reaction" is technically true, but it wasn't a poll or before the changes were made as is implied. Same with "There were very little comments", which leaves out the fact the comments they did get were negative and the low quantity is just from it being a small unknown Discord server.

Re:ImageGlass added malware with this commit by kzrdude on Saturday January 22, 2022 @11:27AM (#30038028)
Looking at how he named the commit that introduced it.. it just stinks, looks like it's trying to go in unnoticed.

Or sadly, that commit log standards are nonexistent and don't have to describe the changes and be misleading, it's one of those.

Re:ImageGlass added malware with this commit by stefan_ on Saturday January 22, 2022 @10:55AM (#30037711)
The guy deceptively enlisted thousands of users into a botnet without notification and likely through auto-update mechanisms (such as the Windows app store). That sounds criminal.
Re:ImageGlass added malware with this commit by Rd6n6 on Saturday January 22, 2022 @11:05AM (#30037815)
It’s not auto updated on windows, it’s an annoying pop up suggesting you go download a latest version, thankfully
Re:ImageGlass added malware with this commit by tethys on Saturday January 22, 2022 @11:07AM (#30037839)
From the guy:

> ImageGlass Store version is not affected.

Re:ImageGlass added malware with this commit by Hamuko on Saturday January 22, 2022 @11:26AM (#30038022)
Does the Windows Store not allow you to sneak in proxies to user machines?
Re:ImageGlass added malware with this commit by gruez on Saturday January 22, 2022 @11:39AM (#30038172)
It's paid for, so I guess it would be in bad taste to have that included. At least the free one you can argue it's ad-supported or whatever.
Re:ImageGlass added malware with this commit by kadoban on Saturday January 22, 2022 @12:02PM (#30038466)
"ad-supported" and "malware" are not the same thing.
Re:ImageGlass added malware with this commit by andi999 on Saturday January 22, 2022 @11:11AM (#30037879)
Maybe the author is located in a country with weak cyber crime laws (and does not intendl to leave it).
Re:ImageGlass added malware with this commit by chillstreem on Saturday January 22, 2022 @02:09PM (#30039796)
IIRC the author is from and lives in Vietnam.
Re:ImageGlass added malware with this commit by edflsafoiewq on Saturday January 22, 2022 @10:57AM (#30037741)
Shipping malware is not a mistake. The amount of people simping for this guy is unreal.
Re:ImageGlass added malware with this commit by sph on Saturday January 22, 2022 @11:11AM (#30037873)
"Poor guy doing open source takes dumb decision because they need money" is a sorry excuse I've been hearing too much lately.
Re:ImageGlass added malware with this commit by aspaviento on Saturday January 22, 2022 @11:16AM (#30037926)
And quite distasteful when many people have collaborated on your software. If you deserve some compensation, what about all of them? Will you share whatever you earn from it?
Re:ImageGlass added malware with this commit by Snetry on Saturday January 22, 2022 @11:29AM (#30038055)
> And quite distasteful when many people have collaborated on your software. If you deserve some compensation, what about all of them? Will you share whatever you earn from it?

Most contributions are from drive by contributor's that may not even use the project.

Neither those nor the maintainer are entitled to compensation, but open source is a cruel environment where people want to use what you made but they wouldnt give you a dime unless they had to

Re:ImageGlass added malware with this commit by njloof on Saturday January 22, 2022 @11:25AM (#30038018)
Maybe it’s time we re-examine the value prop for open source authors
Re:ImageGlass added malware with this commit by ravel-bar-foo on Saturday January 22, 2022 @11:36AM (#30038136)
Everyone knows their value prop going in: unless you are able to monetize the complement like RedHat or Google, payment is in experience, reputation, and a fun challenge.
Re:ImageGlass added malware with this commit by domador on Saturday January 22, 2022 @12:11PM (#30038559)
Very idealistic people might not realize this as they start working on their project.

I wish it was otherwise, people, but it's usually "build it and they WON'T come" ("they" being the funds needed to make a living.)

Re:ImageGlass added malware with this commit by atq2119 on Sunday January 23, 2022 @01:53AM (#30044198)
Payment can also appear in the form of collaborators helping improve a tool you want for yourself, especially if you choose the right license.
Re:ImageGlass added malware with this commit by hobs on Saturday January 22, 2022 @11:02AM (#30037790)
Hell no it was not in good faith - if this makes you think that you shouldn't do open source because of people having malware patched into their system to profit some guy, please, never do it.
Re:ImageGlass added malware with this commit by kadoban on Saturday January 22, 2022 @10:56AM (#30037732)
The author added malware to the project. That's about as user hostile as it gets, and hostility breeds hostility.
Re:ImageGlass added malware with this commit by Hallucinaut on Saturday January 22, 2022 @11:02AM (#30037789)
A reverse hostility sandwich, if you will
Re:ImageGlass added malware with this commit by kadoban on Saturday January 22, 2022 @11:13AM (#30037896)
xD fixed the typo
Re:ImageGlass added malware with this commit by roywiggins on Saturday January 22, 2022 @11:02AM (#30037784)
How do you conclude that quietly integrating malware into an image viewer was done "in good faith"? Because the author didn't twirl their mustache when they did it and claimed surprise that people were mad?
Re:ImageGlass added malware with this commit by jacquesm on Saturday January 22, 2022 @11:33AM (#30038103)
This is not a 'good faith' action. It is a way to try to monetize your users bandwidth in a way that exposes them to liability. It is so far across the line that it is sad that that needs to be explained.
Re:ImageGlass added malware with this commit by baskethead on Saturday January 22, 2022 @11:01AM (#30037781)
You have it backwards. Open source is the reason why it was detected. Closed source would have made it extremely hard to find.
Re:ImageGlass added malware with this commit by msla on Saturday January 22, 2022 @11:15AM (#30037908)
For the poster you're responding to, I get the impression that their main goal is to avoid dealing with angry users, so people not noticing the change would have been a feature, not a bug.
Re:ImageGlass added malware with this commit by na85 on Saturday January 22, 2022 @11:12AM (#30037888)
>Was it in good faith?

On what planet could this be considered good faith?

Re:ImageGlass added malware with this commit by ryandrake on Saturday January 22, 2022 @11:01AM (#30037772)
I was struck by the stark difference in tone among so few commenters. There were firm, constructive, factual feedbacks, and aggressive, inflammatory personal attacks (“how can anyone trust you?”). Laid bare like that, it is so obvious which approach is better and most effective. Obviously the maintainer made a terrible decision, but there’s a right way and a wrong way to suggest correction.

We need more martinlindhes in open source and fewer Yakabuffs.

Re:ImageGlass added malware with this commit by roywiggins on Saturday January 22, 2022 @11:04AM (#30037807)
Well, it's a good question. How can you trust someone who thought this was okay? Even if they're just too ignorant to realize what they were doing, that's also a good reason not to trust them. What else will they think is a good idea?
Re:ImageGlass added malware with this commit by ryandrake on Saturday January 22, 2022 @11:18AM (#30037944)
These are all legitimate questions, but when you phrase them that way and address them to the maintainer, consider how the message will be received. He is likely to consider it an attack, and will be tempted to mount a defense. Now, instead of a constructive problem-solving discussion, you have a destructive battle—one that does not move things forward towards the goals: removing the change and preventing further bad decisions.
Re:ImageGlass added malware with this commit by kadoban on Saturday January 22, 2022 @11:22AM (#30037988)
There is no constructive criticism possible and no possible further relationship. If I'd been a user of this project, I'd be reformatting my PC and restoring from backups, and the nasty message I'd leave on github would only be intended to warn others away from this toxic person's code.
Re:ImageGlass added malware with this commit by roywiggins on Saturday January 22, 2022 @11:33AM (#30038104)
If someone conspired to enroll my computer in a botnet, constructive problem solving would not be the first thing on my mind, and in fact I don't see how it could be my responsibility. If I fuck up very badly and people are mad and unconstructive, that's unpleasant but the problem is my fuckup, not people being mad about it in the wrong way.

It seems to me that it's up to the author to explain why the project can still be trusted, they can't just do this and expect that people will still trust them just because they reverted it.

Re:ImageGlass added malware with this commit by schleck8 on Saturday January 22, 2022 @11:04AM (#30037808)
You are right.

everyone makes a mistake at some point and the fact that the dev used the ip hijacking service's name in the commit message to me signals that he wasn't aware of how shady it is

Even if he was, a comment like "I don't think this is acceptable and will fork" is a lot more appropriate than "don't talk shit"