Pre-commit: framework for managing/maintaining multi-language pre-commit hooks

Re:Pre-commit: framework for managing/maintaining multi-lang... by jen20 on Tuesday December 21, 2021 @10:16AM (#29638140)

That’s a pretty reductive attitude towards linters. If writing Go (for example), linters will tell you if you have ineffective assignments, or have neglected to check an error value - both things that may well block releases.

While one could argue these are the job of the compiler, they are not today, and so linting during CI is not only appropriate, but practically required.

[ Parent | on HN ]

Re:Pre-commit: framework for managing/maintaining multi-lang... by fivea on Tuesday December 21, 2021 @03:09PM (#29641504)

> While one could argue these are the job of the compiler, they are not today, and so linting during CI is not only appropriate, but practically required.

I disagree. Stylistic choices should not block a pipeline. It's impossible to argue in favour of blocking a release just because there's a whitespace in a place where it makes some random developer frown. The robustness principle also applies here.

And no, build/critical errors are not the same as stylistic/linting errors.

[ Parent | on HN ]

Re:Pre-commit: framework for managing/maintaining multi-lang... by jen20 on Tuesday December 21, 2021 @03:32PM (#29641758)

Whether you check errors is a correctness issue, not a stylistic one.

[ Parent | on HN ]

Re:Pre-commit: framework for managing/maintaining multi-lang... by giovannibonetti on Tuesday December 21, 2021 @11:00AM (#29638624)

The fact that Go requires a linter to ensure errors are properly handled is a whole other topic

[ Parent | on HN ]

Re:Pre-commit: framework for managing/maintaining multi-lang... by jen20 on Tuesday December 21, 2021 @03:32PM (#29641751)

I don’t disagree there.

[ Parent | on HN ]