News for hackers. Stuff that matters.
Re:Code Review as a Service by jermaustin1 on Monday December 20, 2021 @08:53AM (#29624927)
But almost any good SA can catch all of those issues, a person doesn't need to look through the code for that.
Re:Code Review as a Service by senko on Monday December 20, 2021 @08:57AM (#29624971)
This is very close to saying Halting problem is not, in fact, a problem: https://brilliant.org/wiki/halting-problem/
Re:Code Review as a Service by adgjlsfhk1 on Monday December 20, 2021 @09:28AM (#29625263)
This isn't quite true because in most real world scenarios, one of the requirements for code to be correct is that it provably halts in a fairly limited amount of time.
Re:Code Review as a Service by jermaustin1 on Monday December 20, 2021 @09:17AM (#29625163)
Not at all, it is saying that if the only things this service is providing is a human doing SA (since they dont have any deep-knowledge of the codebase), then you could just use an SA.

Code review in the real world misses the Halting problem, the only way you can really see it is if you know the codebase well enough to SEE it, and any 3rd party that is given a pull request to complete in a timely manner will not have time to fully learn your code base or even the modules you are submitting.

Re:Code Review as a Service by reuben364 on Monday December 20, 2021 @09:44AM (#29625420)
A human being doesn't solve the halting problem either.
Re:Code Review as a Service by samatman on Monday December 20, 2021 @11:00AM (#29626316)
Ironically, it very seldom is.

It's Rice's Theorem which tends to get me in trouble!