How I learned to stop worrying and push to master

Re:How I learned to stop worrying and push to master by Ozzie_osman on Thursday December 16, 2021 @07:56PM (#29586281)

I've found that to be a great middle ground on most teams.

If you want to stretch it a little more, you could selectively do post-merge reviews for things that might be low risk (ie a UI change that's behind a feature flag that only your team sees), and keep riskier changes (like a big refactor, a data migration, etc) on the pre-merge review flow.

[ Parent | on HN ]

Re:How I learned to stop worrying and push to master by deckiedan on Friday December 17, 2021 @02:04AM (#29588878)

We have pre merge review - but for trivial stuff, text / label changes, etc, put a "tiny" tag on the PR, and if urgent paste it to the slack channel asking for a glance and nod review...

At least having another pair of eyes check text-only changes has caught so many typos, etc, and only takes a couple minutes.

[ Parent | on HN ]