If you care about having 20 hours of battery life instead of 8-10, the m1 is definitely going to win that. But from a pure performance perspective there are chips on the market faster than the m1 in the laptop sphere from AMD already.
If you get an zephyrus with an AMD cpu and a dedicated GPU you will pay less than the macbook pro and be more performant, in exchange for a hotter laptop with lower battery life. But that's just a tradeoff, not necessarily a win one way or another. I've never needed 20 hours of battery life and I don't prioritize it. 8-10 is enough for me. I'd rather have the faster machine.
And I can change the SSD or RAM myself without expecting it to make itself implode later in its lifespan because its all in one package as the apple silicon is.