News for hackers. Stuff that matters.
Re:Goodbye, Clean Code (2020) by postalrat on Tuesday November 16, 2021 @12:17PM (#29243256)
It was reviewed the next day by his boss.

How is pushing to master not a form of CI?

Re:Goodbye, Clean Code (2020) by the_arun on Tuesday November 16, 2021 @12:24PM (#29243364)
> It was reviewed the next day by his boss.

Assuming Master is the "protected branch" and not kitchen sink, this sounds like - "we test only in production". Wouldn't or shouldn't reviews happen before merging to master?

Re:Goodbye, Clean Code (2020) by donatj on Tuesday November 16, 2021 @12:32PM (#29243485)
I was going to downvote you, but then you made me think - everyone pushing to a shared branch is the most continuous form of continuous integration I suppose.

I worked this way for years before we moved into full branched code review. I would never go back however.

That said, you should still have at least some review and automated testing before your code gets in everyone else's way.

Re:Goodbye, Clean Code (2020) by deeviant on Tuesday November 16, 2021 @12:23PM (#29243358)
Likely, it was their coworker who saw the changes, then reported the incident to the manager, rather than some sort of manager picking through every commit type process.