News for hackers. Stuff that matters.

A comment on Gitlab servers are being exploited in DDoS attacks. Parent comment

Re:Gitlab servers are being exploited in DDoS attacks by rsj_hn on Thursday November 04, 2021 @08:26PM (#29114100)
I saw a very similar thing with eval. There was an evaluation of a nested JSON object

    x["a"]["b"]["c"]
And the developer decided that this was best evaluated by eval. During the code review phase I talked to them and asked why they were using eval, and they didn't know it could be evaluated directly as they were a little unclear if javascript supported that syntax.
[ Parent | on HN ]
Re:Gitlab servers are being exploited in DDoS attacks by jdc on Thursday November 04, 2021 @08:59PM (#29114307)
How much longer did said dev continue working there?
[ Parent | on HN ]
Re:Gitlab servers are being exploited in DDoS attacks by dylan604 on Thursday November 04, 2021 @09:21PM (#29114438)
Fire the dev, or educate the dev. Sure, eval is just a sure sign of a lot of lack of understanding, but I'd hope for something less vile as eval would be a little more understanding that everyone learns something sometime
[ Parent | on HN ]
Re:Gitlab servers are being exploited in DDoS attacks by iratewizard on Thursday November 04, 2021 @10:22PM (#29114782)
It's gross negligence of the dev is only a Javascript dev, but maybe understandable if it's just one of the three languages he uses regularly. I probably wouldn't fire, but I also can't imagine any of my devs doing that.
[ Parent | on HN ]
Re:Gitlab servers are being exploited in DDoS attacks by rsj_hn on Thursday November 04, 2021 @09:05PM (#29114343)
err, no comment
[ Parent | on HN ]
Re:Gitlab servers are being exploited in DDoS attacks by dylan604 on Thursday November 04, 2021 @09:21PM (#29114441)
that dev is now your manager? /s
[ Parent | on HN ]
Re:Gitlab servers are being exploited in DDoS attacks by RexM on Thursday November 04, 2021 @09:42PM (#29114565)
He is the dev
[ Parent | on HN ]
Re:Gitlab servers are being exploited in DDoS attacks by rsj_hn on Thursday November 04, 2021 @10:37PM (#29114892)
LOL, no to both!
[ Parent | on HN ]