But he’s wrong based on Star Trek canon (and throughout this I am not referencing Discovery and concurrent series, which are charged with being a change of tone) except maybe on war, and even then only if you take “on Earth” to mean, for war, “between nations of Earth, since they are all subordinated to a single government” and not “physically occurring on Earth”.
> Picard tells Lilly in the same movie that money is no longer used
This may be true on Earth, which seems like it uses centralized (possibly exchangeable) centralized rationing rather than (or at least to an extent that most people need not, if they do not choose to, interact with) a money economy, though profit-seeking independent traders exist in Federation space at least in the TOS era, and Federation citizens have and spend various forms of money for various things throughout the various series.
I think pre-1968 if there were fan theories by that point, they wouldn't have been so drawn to calling out some optimism that doesn't make sense.
But I really haven't watched enough Star Trek let alone caught up with fan theories to carry this further :).
Did George Takei get casted thinking "fuck this bullshit, I'm going to subtlety undermine the nonsense utopia with my acting?" Or was the pain and skepticism of cold war rhetoric more a subconscious war of vacillating between hope for the future, and skepticism that "United Space Ship" and "United States Ship" had enough distance between them?
I don't think many people were on that former level, say, pre-1968 at least.
At least until the recent Star Trek, fans understood the Federation to be utopian. That was Gene Roddenberry's optimistic view of human potential. That we would get past our current issues. Q even puts the Enterprise crew on trial in TNG's first episodes for various historical crimes, and Picard is able to argue that humanity has evolved past much of that.
It's only really with external threats and other cultures that the Federation's values are challenged, and sometimes compromised.