It depends on the timeframe. First, you got a lot in dividends (which were much higher rates than today’s dividends on average). Secondly, by the end of the war, you were at least break even, and by the early 1950’s you probably more than doubled your money.
Now, if you had been patient and been optimistic in 1932/3 at the very bottom of the market, you would have made a killing, nearly 10x your investment by the early 1950’s, plus all the dividends!
But, I get your point and agree with the rest of your comment.
Especially if you have to pay tax on the "profit".
Okay - sure - maybe given the environment, "good" investments were few and hard to come by.
1968-1982, the S&P 500 essentially went nowhere.
1998-2012, the S&P 500 essentially went nowhere.
Those dead periods represent ~28 out of the last ~53 years.
That's a long time for the market to produce mediocre results, especially compared to expectations today.
The long-term chart and valuations of the S&P 500 are looking pretty comical at this point, in terms of irrational exuberance in the present. It's pricing in an extraordinary economic golden era of super growth, which isn't going to happen.
This is basically the same as saying 2005-2020. Just because there was a temporary crash for one year, does not mean 1998-2012 was a bad time for investment.
The US Government was well into its asset subsidization spree by then. 1999 tech stocks were not a good investment. Other than that, this was a pretty good time to invest.
It didn't pay off to be optimistic in 1930.
The government got into the business of subsidizing asset prices at all costs after The Great Depression, and especially after The Subprime Crisis in 2008.
I don't see this ever changing. But if it does, ignorant optimism probably won't be a good strategy anymore.