News for hackers. Stuff that matters.
Re:I ruin developers’ lives with my code reviews and I'm sorry by _gqoa on Wednesday September 15, 2021 @06:51PM (#28545442)
Oh c'mon graybeard, you can't honestly be defending 1500 line components right now can you? It's not even a matter of abstraction choice, it's a matter of simple hygiene.

You know what's worse than the wrong abstractions? Copy and pasting your inline-styled div with a zIndex of 99,999 for the fifth modal in a row because you can't be assed to write a damned display component in anticipation of the next time you'll need to put a Modal together.

Re:I ruin developers’ lives with my code reviews and I'm sorry by slumpt_ on Wednesday September 15, 2021 @09:22PM (#28546772)
No pushback here, I’m moreso suggesting that length is not intrinsically the enemy. I would much rather be debugging or wrangling a long functional component with duplication than a messed up or poor abstraction that’s leaked out elsewhere in the codebase.

Levels to it all. Keep track of painful modules and have strong intent to fix them. Prioritization is a mf.