News for hackers. Stuff that matters.

A comment on I ruin developers’ lives with my code reviews and I'm sorry. Parent comment

Re:I ruin developers’ lives with my code reviews and I'm sorry by X6S1x6Okd1st on Wednesday September 15, 2021 @04:27PM (#28543952)
IMO the absolute worst is excessive criticism while missing a serious business logic or functionality bug.

In my opinion the first priority of code review should be to prevent mistakes in the code at hand

[ Parent | on HN ]
Re:I ruin developers’ lives with my code reviews and I'm sorry by nine_zeros on Wednesday September 15, 2021 @04:55PM (#28544239)
> In my opinion the first priority of code review should be to prevent mistakes in the code at hand

I disagree. The first priority of code review is WHAT problem is it trying to solve and does it actually solve the problem.

If it's not even solving the problem correctly, pedantic nitpicks are inconsequential.

[ Parent | on HN ]
Re:I ruin developers’ lives with my code reviews and I'm sorry by X6S1x6Okd1st on Wednesday September 15, 2021 @05:33PM (#28544654)
Oh yeah I agree, when I said mistakes in the code at hand I was considering a buisness logic bug/failure to 100% be in bound.
[ Parent | on HN ]