The contortions apple is going through to scan locally only really make sense if they are gearing up to do end to end encryption of iCloud photos. I imagine they have other prerequisites before they are ready to announce that as a feature, but if they are not planning to encrypt more why wouldn’t they just scan in the cloud?