IIRC (see the above, it applies to random comments on the internet) drill work is more effective (but feels less effective to both teachers and students) if it's mixed up with different topics or question types, kind of like how doing a kata is better than doing exactly the same punch 10x (obviously katas are not ideal either, at least not as the only tool).

Really you need a bit of diversity, and IMO two of the big traps to fall into are overly homogenous drill work (which doesn't retain as well as mixed drills, but looks effective because anyone who doesn't eat their crayons can do it without thinking too hard) and one-off problems (do an assignment where you solve a heavily obfuscated problem once, then pretend that it's now something that students actually understand, when they've literally just answered one single question assuming they even did it themselves).