Re:Althttpd: Simple webserver in a single C file
by user-the-name on Friday June 11, 2021 @10:10AM
(#27473571)
> And many tech leads simply don't have the time to review every single WIP commit
Do you usually review every commit? I usually just review the diff between the PR'd branch and master, as does everyone I work with.
Re:Althttpd: Simple webserver in a single C file
by pdimitar on Friday June 11, 2021 @10:15AM
(#27473652)
Exactly, and that's why we use squashed commits.
Re:Althttpd: Simple webserver in a single C file
by user-the-name on Friday June 11, 2021 @11:33AM
(#27474718)
Why? You don't need to. GitHub will show you that diff, git itself will show you that diff. There is no need to permanently rewrite history to do this. That makes no sense.
Re:Althttpd: Simple webserver in a single C file
by pdimitar on Friday June 11, 2021 @11:38AM
(#27474773)
For the last time: squashed commits help teams who need the main branch be a high-level history of delivered features and fixed bugs. Where one commit is one delivered feature or a bug fixed. That's the idea.
Whether you think that "makes no sense" is inconsequential. Many people find it very meaningful.
And many tech leads simply don't have the time to review every single WIP commit. They want meaningful message/description of the big squashed PR commit. If you just post a merged list of all commit messages with 10x "fix stuff" inside you'll be in big trouble the next time around and your work will be inspected very closely.
The practices I am describing to you are reality in many tech companies. Writing code there is not about you at all. And almost nobody will read your code and PR descriptions unless they really have to. Hence it's a professional courtesy to make those as small and meaningful as possible.