News for hackers. Stuff that matters.
Re:Things Everyone Should Do: Code Review by brown9-2 on Wednesday July 06, 2011 @06:40PM (#2736289)
how does the reviewer look at your diffs and code if your changes haven't yet been committed?

Where I work we have a pretty simple script which diffs each file in the Perforce changelist against your local copy and sends it in an email to the team, with some pretty formatting for added/removed/changed lines.

Discussion then takes place over email, which for 99% of changes is good enough since the teams are small.

There are no comments on this comment yet.